Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the memroy leak in the parser when parse admin job operation. #2238

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Fix the memroy leak in the parser when parse admin job operation. #2238

merged 1 commit into from
Jul 21, 2020

Conversation

Shylock-Hg
Copy link
Contributor

What changes were proposed in this pull request?

Why are the changes needed?

Will break the compatibility? How if so?

Does this PR introduce any user-facing change?

How was this patch tested?

Checklist

  • I've run the tests to see all new and existing tests pass
  • If this Pull Request resolves an issue, I linked to the issue in the text above
  • I've informed the technical writer about the documentation change if necessary

@Shylock-Hg Shylock-Hg added type/bug Type: something is unexpected ready-for-testing PR: ready for the CI test labels Jul 20, 2020
dangleptr
dangleptr approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@dangleptr dangleptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Well done.

liuyu85cn
liuyu85cn approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@liuyu85cn liuyu85cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dangleptr dangleptr merged commit 61b6976 into vesoft-inc:master Jul 21, 2020
xuguruogu pushed a commit to xuguruogu/nebula that referenced this pull request Aug 5, 2020
@Shylock-Hg @xuguruogu
Fix the memroy leak in the parser when parse admin job operation. (ve…
4a2b5d2 
…soft-inc#2238)
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
@Shylock-Hg
Fix the memroy leak in the parser when parse admin job operation. (ve…
3f603e5 
…soft-inc#2238)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuyu85cn liuyu85cn liuyu85cn approved these changes

@dangleptr dangleptr dangleptr approved these changes

@critical27 critical27 Awaiting requested review from critical27

@dutor dutor Awaiting requested review from dutor dutor is a code owner

@laura-ding laura-ding Awaiting requested review from laura-ding

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shylock-Hg @dangleptr @liuyu85cn