Correct/go back trace overlap #2203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrect/go-back-trace-overlap
Shylock-Hg
added
in progress
type/bug
dutor
reviewed
Jul 6, 2020
dutor
reviewed
Jul 6, 2020
CPWstatic
reviewed
Jul 6, 2020
src/graph/GoExecutor.cpp
Outdated
| @@ -662,6 +660,47 @@ std::vector<VertexID> GoExecutor::getDstIdsFromResps(std::vector<RpcResponse>::i | |||
| return std::vector<VertexID>(set.begin(), set.end()); | |||
| } | |||
|
|
|||
| std::vector<VertexID> GoExecutor::getDstIdsFromRespWithBackTrack(const RpcResponse &rpcResp) const { | |||
| // back trace in current step | |||
| // To avoid overlap in on step edges | |||
There was a problem hiding this comment.
What do you mean by in on step edges?
| // 6 , 1 | ||
| // 7 , 6 | ||
| // Will mistake lead to 7->6 if insert one by one | ||
| // So read all roots of current step first , then insert them |
There was a problem hiding this comment.
Emm, i'd really appreciate that you could make these comments much more clear if you want the reader to understand what you want to fix.
Comment on lines
1115
to
1124
| // Here if join the input we extend the input rows coresponding to current vertex; | ||
| // Or just loop once as previous that not join anything, | ||
| // in fact result what in responses. | ||
| bool notJoinOnce = false; | ||
| for (auto inputRow = inputRows.first; | ||
| !joinInput || inputRow != inputRows.second; | ||
| joinInput ? ++inputRow : inputRow) { | ||
| for (auto inputRow = inputRows.begin(); | ||
| !joinInput || inputRow != inputRows.end(); | ||
| joinInput ? ++inputRow : inputRow) { | ||
| if (!joinInput) { | ||
| if (notJoinOnce) { | ||
| break; |
There was a problem hiding this comment.
I still want to tell you that it's too complicated here.
Yes. we should. |
In progress. |
… src in current step.
CPWstatic
approved these changes
Jul 7, 2020
xuguruogu
pushed a commit
to xuguruogu/nebula
that referenced
this pull request
Aug 5, 2020
* Fix the go back trace overlap. * Fix some typo. And unnecessary copy by reference. * Fix the note comment. * Add a case to cover the issue that back tracker will overlap the dst, src in current step. Co-authored-by: jude-zhu <51590253+jude-zhu@users.noreply.github.com>
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* Fix the go back trace overlap. * Fix some typo. And unnecessary copy by reference. * Fix the note comment. * Add a case to cover the issue that back tracker will overlap the dst, src in current step. Co-authored-by: jude-zhu <51590253+jude-zhu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
Will affect the GO query over >1 steps and join the previous input.
How was this patch tested?
Checklist