Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[parser] add sentences of DELETE and FIND #220

Merged
merged 2 commits into from
Mar 26, 2019
Merged

[parser] add sentences of DELETE and FIND #220

merged 2 commits into from
Mar 26, 2019

Conversation

zlcook
Copy link
Contributor

@zlcook zlcook commented Mar 20, 2019

add sentences of DELETE and FIND:

  • DELETE VERTEX v_id [, v_id]* WHERE filters
  • DELETE EDGE src_id -> dst_id [, src_id -> dst_id]* WHERE filters
  • FIND pro [,pro]* FROM tag/edge_type WHERE filters

next PR will complete the remaining work : add the corresponding to executor and test case in graph layer

@nebula-community-bot
Copy link
Member

Can one of the admins verify this patch?

@dutor
Copy link
Contributor

dutor commented Mar 25, 2019

Thanks for the effort, and sorry for the delayed review. Could you please do a rebase from upon the upstream?

@zlcook
Copy link
Contributor Author

zlcook commented Mar 25, 2019

Thanks for the effort, and sorry for the delayed review. Could you please do a rebase from upon the upstream?

Done

@dutor
Copy link
Contributor

dutor commented Mar 25, 2019

Jenkins, please run tests

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dutor
Copy link
Contributor

dutor commented Mar 25, 2019

@zlcook It seems there are some confllicts in src/parser/test/ScannerTest.cpp. Can you address those?

@zlcook
Copy link
Contributor Author

zlcook commented Mar 25, 2019

@dutor Done

@dutor
Copy link
Contributor

dutor commented Mar 26, 2019

jenkins please run tests

@nebula-community-bot
Copy link
Member

Unit testing passed.

dutor
dutor approved these changes Mar 26, 2019
View reviewed changes
Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you for taking care of these features.

@dutor dutor merged commit 2049857 into vesoft-inc:master Mar 26, 2019
@dutor dutor deleted the data_modif branch March 26, 2019 05:55
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Feb 16, 2020
@zlcook @dutor
add sentences of DELETE and FIND (vesoft-inc#220)
d6615a4
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
@zlcook @dutor
add sentences of DELETE and FIND (vesoft-inc#220)
af9b019
yixinglu added a commit to yixinglu/nebula that referenced this pull request Mar 21, 2022
@yixinglu
Fix nebula-ent docker latest tag step in workflow (vesoft-inc#220)
6f43bd4 
* Fix nebula-ent docker latest tag step in workflow

* Update major version of docker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dutor dutor dutor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zlcook @nebula-community-bot @dutor