Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue using unreserved aliased keyword as label #2199

Merged
merged 2 commits into from
Jul 1, 2020
Merged

Fixed issue using unreserved aliased keyword as label #2199

merged 2 commits into from
Jul 1, 2020

Conversation

dutor
Copy link
Contributor

@dutor dutor commented Jul 1, 2020

VALUE and VALUES are both recognized as token KW_VALUES, which will be mapped to string values when used as a name_label.

This PR distinguishes these two keywords to fix this issue.

@dutor dutor added the ready-for-testing PR: ready for the CI test label Jul 1, 2020
@dutor dutor merged commit 75a9ca7 into vesoft-inc:master Jul 1, 2020
@dutor dutor deleted the fix-unreserved-aliased-keyword branch July 1, 2020 08:25
@jude-zhu jude-zhu added the v2.0 label Jul 3, 2020
dutor added a commit that referenced this pull request Jul 7, 2020
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
* Fixed issue using unreserved aliased keyword as label

* Fixed UT
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants