Flush rocksdb before clean expired wal #2128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critical27
requested review from
darionyaphet,
dangleptr,
laura-ding,
liuyu85cn,
bright-starry-sky and
panda-sheep
Codecov Report
@@ Coverage Diff @@
## master #2128 +/- ##
==========================================
+ Coverage 86.80% 86.85% +0.05%
==========================================
Files 641 641
Lines 61369 61525 +156
==========================================
+ Hits 53272 53439 +167
+ Misses 8097 8086 -11
Continue to review full report at Codecov.
|
bright-starry-sky
previously approved these changes
May 14, 2020
critical27
dismissed stale reviews from bright-starry-sky, laura-ding, and dangleptr
via
6964e36
dangleptr
approved these changes
May 15, 2020
knightXun
pushed a commit
to knightXun/nebula
that referenced
this pull request
Nov 2, 2020
* flush before clean wal * address comments
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* flush before clean wal * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flush rocksdb before clean expired wal. This pr would fix when a part does not have any input data for a long time, then it crash, the data in rocksdb may have not been flushed to disk, however, the wal has been expired and deleted.