[storage/test] Add the EdgesInterfacesTest to StorageClientTest #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Should be set the edge_type for EdgePropRequests in getEdgeProps interfaces.
|
Well done! @zhangguoqing |
|
Jenkins go |
|
Unit testing passed. |
dangleptr
reviewed
Mar 13, 2019
| retCols.emplace_back( | ||
| TestUtils::propDef(cpp2::PropOwner::EDGE, | ||
| folly::stringPrintf("col_%d", i), | ||
| 3001)); |
There was a problem hiding this comment.
For Edge PropDef, we have no need to set tagId here.
|
Jenkins go |
|
Unit testing passed. |
|
Jenkins go |
|
Unit testing passed. |
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Mar 21, 2022
Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com> Co-authored-by: vince.wu <451943+kikimo@users.noreply.github.com> Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be set the edge_type for EdgePropRequests in getEdgeProps interfaces.