Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when fetch YIELD clause has input prop and input is empty #2042

Merged
merged 3 commits into from
Apr 2, 2020
Merged

Fix crash when fetch YIELD clause has input prop and input is empty #2042

merged 3 commits into from
Apr 2, 2020

Conversation

laura-ding
Copy link
Contributor

No description provided.

@laura-ding laura-ding added ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected labels Apr 1, 2020
Copy link
Contributor

@monadbobo monadbobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jude-zhu jude-zhu requested a review from CPWstatic April 1, 2020 10:37
@codecov-io
Copy link

codecov-io commented Apr 1, 2020

Codecov Report

Merging #2042 into master will decrease coverage by 0.12%.
The diff coverage is 93.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2042      +/-   ##
==========================================
- Coverage   86.90%   86.77%   -0.13%     
==========================================
  Files         636      641       +5     
  Lines       59819    61123    +1304     
==========================================
+ Hits        51984    53039    +1055     
- Misses       7835     8084     +249     
Impacted Files Coverage Δ
src/common/base/Configuration.h 100.00% <ø> (ø)
src/common/utils/NebulaKeyUtils.cpp 100.00% <ø> (ø)
src/common/utils/NebulaKeyUtils.h 90.41% <ø> (ø)
src/common/utils/test/NebulaKeyUtilsTest.cpp 97.10% <ø> (ø)
src/graph/DescribeSpaceExecutor.h 0.00% <ø> (ø)
src/graph/FetchEdgesExecutor.h 0.00% <ø> (ø)
src/graph/FetchExecutor.cpp 88.88% <ø> (+0.59%) ⬆️
src/graph/FetchVerticesExecutor.h 0.00% <ø> (ø)
src/graph/GoExecutor.h 56.25% <ø> (ø)
src/graph/GraphService.h 100.00% <ø> (ø)
... and 205 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8810ecc...21fe855. Read the comment docs.

@dutor dutor merged commit eea7407 into vesoft-inc:master Apr 2, 2020
jude-zhu pushed a commit to jude-zhu/nebula that referenced this pull request Apr 2, 2020
Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
(cherry picked from commit eea7407)
dutor pushed a commit that referenced this pull request Apr 2, 2020
* remove bigint because we dont support it (#2031)

Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
(cherry picked from commit 3423df1)

* fix crash (#2042)

Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
(cherry picked from commit eea7407)

* Sampling apply to all edges starting from a vertex. (#2013)

* Sampling from all edges.

* Update test for sampling multi edges.

* Testing both inbound and outbound.

* Fix clang compiling problem.

* Update the sampling.

Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
(cherry picked from commit 8810ecc)

* Fix the error when vertex/edge not exist if update. (#2025)

* Fix the error when vertex/edge not exist if update.

* Optimize the atomic error logical.

* Fix one alignment.

Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
(cherry picked from commit 9fc4e7f)

* Correct issue 2009 which the timestamp default value for edge not treat. (#2038)

* Correct issue 2009 which the timestamp default value for edge not treat.

* Add the cover cases.

* Fix one typo.

Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
(cherry picked from commit 4aa9217)

Co-authored-by: flyingcat <1004815462@qq.com>
Co-authored-by: laura-ding <48548375+laura-ding@users.noreply.github.com>
Co-authored-by: CPWstatic <13495049+CPWstatic@users.noreply.github.com>
Co-authored-by: Shylock Hg <33566796+Shylock-Hg@users.noreply.github.com>
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Jan 31, 2023
* add tagFilter for traverse

* add test case

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

Co-authored-by: jimingquan <mingquan.ji@vesoft.com>
Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants