Fix some typo. Add more cases about integer hex oct range checking. #1916
Conversation
src/parser/parser.yy
Outdated
| $$ = new PrimaryExpression($1); | ||
| } | ||
| | MINUS INTEGER { | ||
| ifOutOfNegativeRange($2, @2); |
There was a problem hiding this comment.
the INTEGER on here can’t out of the min of INTEGER，don't need ifOutOfNegativeRange
src/parser/parser.yy
Outdated
| } | ||
| } | ||
|
|
||
| void ifOutOfNegativeRange(const int64_t input, |
There was a problem hiding this comment.
The scanner has guaranteed no more than 9223372036854775808. Negative Numbers do not need to be checked
There was a problem hiding this comment.
Hex/Oct don't guaranteed.
There was a problem hiding this comment.
So I plan to check hex/oct number length when lex.
src/parser/parser.yy
Outdated
| void ifOutOfRange(const int64_t input, | ||
| const nebula::GraphParser::location_type& loc) { | ||
| if ((uint64_t)input == 9223372036854775808ULL) { | ||
| throw nebula::GraphParser::syntax_error(loc, "out of range"); | ||
| if ((uint64_t)input > 9223372036854775807ULL) { |
There was a problem hiding this comment.
replace with == MAX_INTEGER
src/parser/scanner.lex
Outdated
| @@ -17,6 +17,8 @@ using TokenType = nebula::GraphParser::token; | |||
|
|
|||
| static constexpr size_t MAX_STRING = 4096; | |||
|
|
|||
| static constexpr size_t MAX_INTEGER = 9223372036854775808ULL; | |||
There was a problem hiding this comment.
MIN, ABS is to describe the MIN_INTEGER.
There was a problem hiding this comment.
I don't think it's clear, I think maybe MAX_ABS_INTEGER better.
Codecov Report
@@ Coverage Diff @@
## master #1916 +/- ##
=========================================
Coverage ? 86.93%
=========================================
Files ? 636
Lines ? 59913
Branches ? 0
=========================================
Hits ? 52084
Misses ? 7829
Partials ? 0
Continue to review full report at Codecov.
|
…esoft-inc#1916) * Fix some typo. Add more cases about integer hex oct range checking. * Check the integer limit when lex. * Let the hex/oct scanner case more property. * Share the MAX_INTEGER in lex/parser. * Change the constant name Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
What changes were proposed in this pull request?
Add integer range checking cases about dec/hex/oct.
Fix the origin checking error which can't check hex/oct accurately
Fix some typo.
Why are the changes needed?
Add the checking to hex/oct to avoid if user store a number
+0xFFFFFFFFFFFFFFFFwe tell him it's negative, because now we filled the literal as uint64_t and cast to int64_t later.Does this PR introduce any user-facing change?
NO
How was this patch tested?