Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix graph client print bad when auth failed. #1867

Merged

Conversation

CPWstatic
Copy link
Contributor

Actually, it prints nothing. But, it is better than printing an address.

$ ./bin/nebula -u=user
Password: E0304 17:57:39.003026 30347 GraphClient.cpp:49] Failed to authenticate "user":
Connection failed

@yixinglu yixinglu added the ready-for-testing PR: ready for the CI test label Mar 4, 2020
@jude-zhu jude-zhu requested a review from laura-ding March 9, 2020 02:41
@jude-zhu jude-zhu added this to the R201910_RC4 milestone Mar 9, 2020
@Shylock-Hg
Copy link
Contributor

Close #1326

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@ba8b3f6). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1867   +/-   ##
=========================================
  Coverage          ?   86.74%           
=========================================
  Files             ?      630           
  Lines             ?    58683           
  Branches          ?        0           
=========================================
  Hits              ?    50903           
  Misses            ?     7780           
  Partials          ?        0
Impacted Files Coverage Δ
src/client/cpp/GraphClient.cpp 68.42% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba8b3f6...f245733. Read the comment docs.

@dangleptr dangleptr merged commit 5294d63 into vesoft-inc:master Mar 9, 2020
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants