Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc]add charset #1750

Merged
merged 2 commits into from
Feb 28, 2020
Merged

[doc]add charset #1750

merged 2 commits into from
Feb 28, 2020

Conversation

amber-moe
Copy link
Contributor

What changes were proposed in this pull request?

Add charset and collation doc.
code PR #1709

Copy link

@wilsonyou wilsonyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

Copy link
Contributor

@whitewum whitewum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job

@@ -29,9 +29,13 @@ CREATE SPACE [IF NOT EXISTS] <space_name>

* _replica_factor_

_replica_factor_ 表示副本数量。默认值是 1,集群建议为 3
_replica_factor_ 表示副本数量。默认值是 1,集群建议为 3。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panda-sheep 字符集会引入任何历史兼容性问题吗?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is UTF8, there will be no compatibility problems.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when charset compare and display #1782 merged, order by and string compare may be different

@jude-zhu jude-zhu added the ready-for-testing PR: ready for the CI test label Feb 28, 2020
@dangleptr dangleptr merged commit 4204298 into vesoft-inc:master Feb 28, 2020
@amber-moe amber-moe deleted the charset-support branch March 2, 2020 00:38
jude-zhu pushed a commit to jude-zhu/nebula that referenced this pull request Mar 4, 2020
Co-authored-by: dangleptr <37216992+dangleptr@users.noreply.github.com>
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
Co-authored-by: dangleptr <37216992+dangleptr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants