Remove CHECK and FATAL in graphd #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit testing passed. |
1 similar comment
|
Unit testing passed. |
monadbobo
reviewed
Dec 24, 2019
|
Unit testing passed. |
whitewum
reviewed
Dec 25, 2019
| @@ -71,7 +71,8 @@ class GroupByHash { | |||
| return 0; | |||
| } | |||
| default: { | |||
| LOG(FATAL) << "Untreated value type: " << static_cast<int32_t>(col.getType()); | |||
| LOG(ERROR) << "Untreated value type: " << static_cast<int32_t>(col.getType()); | |||
| return 0; | |||
There was a problem hiding this comment.
return 0 or other error code?
|
Unit testing passed. |
|
relate to #1184 |
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* remove CHECK in graphd * Remove FATAL in graphd * rebase upstream * fix error message and spelling mistakes Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.