fix UT failed in GCC 9.1.1 #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critical27
requested review from
darionyaphet,
dangleptr,
laura-ding,
liuyu85cn and
bright-starry-sky
|
Unit testing passed. |
bright-starry-sky
approved these changes
Dec 19, 2019
|
Unit testing passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for feeding back @laura-ding.
The output of
Balancer::sortedHostsByPartsis not the same among different version of gcc (node arrangement in unordered_map not same).Actually, we can't verify the balance task num and task source (in this case, gcc 9.1.1 generate one more task). Instead, we just check the partition allocation after balance.