Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan through the last wal in case wal is cut off. #1194

Merged
merged 7 commits into from
Nov 5, 2019

Conversation

critical27
Copy link
Contributor

No description provided.

@critical27 critical27 changed the title Scan through the last wal to in case wal is cut off. Scan through the last wal in case wal is cut off. Nov 1, 2019
@critical27 critical27 added the ready-for-testing PR: ready for the CI test label Nov 1, 2019
src/kvstore/wal/FileBasedWal.cpp Outdated Show resolved Hide resolved
src/kvstore/wal/FileBasedWal.cpp Outdated Show resolved Hide resolved
@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@critical27 critical27 added in progress and removed ready-for-testing PR: ready for the CI test labels Nov 1, 2019
@critical27 critical27 added ready-for-testing PR: ready for the CI test and removed in progress labels Nov 1, 2019
@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

dangleptr
dangleptr previously approved these changes Nov 1, 2019
Copy link
Contributor

@dangleptr dangleptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. LGTM.
We could clean the code in iterator in the future.

@nebula-community-bot
Copy link
Member

Unit testing passed.

darionyaphet
darionyaphet previously approved these changes Nov 4, 2019
@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

1 similar comment
@nebula-community-bot
Copy link
Member

Unit testing passed.

@dangleptr dangleptr merged commit 75326df into vesoft-inc:master Nov 5, 2019
@critical27 critical27 deleted the fix-wal branch November 6, 2019 10:05
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
* fix wal

* add more ut

* address @dangleptr's comments

* truncate when rollback or last wal is illegal

* update

* fix ut
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Jan 31, 2023
* Optimize for k-hop

* update third party version

Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants