-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scan through the last wal in case wal is cut off. #1194
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critical27
requested review from
dutor,
darionyaphet,
sherman-the-tank,
CPWstatic,
dangleptr,
laura-ding and
liuyu85cn
October 31, 2019 14:04
critical27
changed the title
Scan through the last wal to in case wal is cut off.
Scan through the last wal in case wal is cut off.
Nov 1, 2019
dangleptr
reviewed
Nov 1, 2019
dangleptr
reviewed
Nov 1, 2019
Unit testing passed. |
Unit testing passed. |
critical27
added
in progress
and removed
ready-for-testing
PR: ready for the CI test
labels
Nov 1, 2019
critical27
added
ready-for-testing
PR: ready for the CI test
and removed
in progress
labels
Nov 1, 2019
Unit testing passed. |
Unit testing passed. |
dangleptr
previously approved these changes
Nov 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done. LGTM.
We could clean the code in iterator in the future.
Unit testing passed. |
darionyaphet
previously approved these changes
Nov 4, 2019
Unit testing passed. |
Unit testing passed. |
1 similar comment
Unit testing passed. |
darionyaphet
approved these changes
Nov 4, 2019
dangleptr
approved these changes
Nov 5, 2019
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* fix wal * add more ut * address @dangleptr's comments * truncate when rollback or last wal is illegal * update * fix ut
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Jan 31, 2023
* Optimize for k-hop * update third party version Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.