Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker related configuration #1074

Merged
merged 12 commits into from
Oct 28, 2019
Merged

Update docker related configuration #1074

merged 12 commits into from
Oct 28, 2019

Conversation

yixinglu
Copy link
Contributor

@yixinglu yixinglu commented Oct 15, 2019

  • Export ports of nebula services in vesoft/nebula-graph docker image
  • Reset log level in docker image
  • Set stderr threshold in nebula graph configure file rather than graph daemon implementation
  • Update CI configuration for package and build nebula
  • Change package script parameter about package type: RPM or DEB

reference

@yixinglu yixinglu requested review from dutor, laura-ding, critical27, CPWstatic and dangleptr and removed request for dutor October 15, 2019 01:39
@yixinglu yixinglu added the ready-for-testing PR: ready for the CI test label Oct 15, 2019
@nebula-community-bot
Copy link
Member

Unit testing passed.

dutor
dutor previously approved these changes Oct 15, 2019
Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nebula-community-bot
Copy link
Member

Unit testing passed.

1 similar comment
@nebula-community-bot
Copy link
Member

Unit testing passed.

dutor
dutor previously approved these changes Oct 16, 2019
@nebula-community-bot
Copy link
Member

Unit testing passed.

5 similar comments
@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@yixinglu yixinglu changed the title Reset log level in docker image and fix rpm package error Reset log level in docker image Oct 24, 2019
@nebula-community-bot
Copy link
Member

Unit testing passed.

1 similar comment
@nebula-community-bot
Copy link
Member

Unit testing passed.

@yixinglu yixinglu changed the title Reset log level in docker image Update docker related configuration Oct 24, 2019
@nebula-community-bot
Copy link
Member

Unit testing passed.

Fold too long line in Dockerfile

Decrease data loading interval seconds and fix typos
Comment exposed ports

Format commands

Increase number worker threads

Export ports of web server

Add build docker image bash

Fix nebula spec

Add package and build matrix test

Fix expose ports in docker compose yaml file

Upgrade new docker image and docker-compose deployment method

Mount local directory to container

Ignore docker data/logs folders

Restart on failure
vesoft/nebula-docker-compose

Fix docker image tag
@nebula-community-bot
Copy link
Member

Unit testing passed.

5 similar comments
@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

.github/workflows/build.yaml Show resolved Hide resolved
package/package.sh Outdated Show resolved Hide resolved
.github/workflows/docker.yaml Show resolved Hide resolved
docker/build-images.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@laura-ding laura-ding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

src/graph/GraphService.h Show resolved Hide resolved
src/daemons/GraphDaemon.cpp Show resolved Hide resolved
Ignore docs path for build workflow

Use short commit sha when no version

Exact match

Add badge image link

Address comments of PR review
@nebula-community-bot
Copy link
Member

Unit testing passed.

@yixinglu yixinglu requested a review from laura-ding October 25, 2019 09:47
Shylock-Hg
Shylock-Hg previously approved these changes Oct 25, 2019
@nebula-community-bot
Copy link
Member

Unit testing passed.

laura-ding
laura-ding previously approved these changes Oct 25, 2019
@yixinglu yixinglu dismissed stale reviews from laura-ding and Shylock-Hg via d9ccb27 October 26, 2019 03:10
@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dangleptr dangleptr merged commit a1d8ebe into vesoft-inc:master Oct 28, 2019
@yixinglu yixinglu deleted the some-fixes branch October 28, 2019 05:28
yixinglu added a commit to yixinglu/nebula that referenced this pull request Feb 16, 2020
* Reset log level and stderrthreshold

Fold too long line in Dockerfile

Decrease data loading interval seconds and fix typos

* Set default constructor and destructor

Comment exposed ports

Format commands

Increase number worker threads

Export ports of web server

Add build docker image bash

Fix nebula spec

Add package and build matrix test

Fix expose ports in docker compose yaml file

Upgrade new docker image and docker-compose deployment method

Mount local directory to container

Ignore docker data/logs folders

Restart on failure

* Move docker-compose configure file to other repo

vesoft/nebula-docker-compose

Fix docker image tag

* Use matrix of action to parallel jobs

* Update package script

Delete package type parameter for package script

Fix package errors

Source bash environment variables

Add BASH_ENV variable

Use absolute path for cmake and ctest

Add library path

Add nebula bin env variable

Test package

Test env variable for library path

Fix package project path error

Update env variables

Fix system check branch error

* Rename ci workflow file

* Fix package error

* Rename and cancel multithreads for ctest in CI

* Try test in singlethread and add tag release package trigger

* Fix uploaded artifacts name

Ignore docs path for build workflow

Use short commit sha when no version

Exact match

Add badge image link

Address comments of PR review
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
* Reset log level and stderrthreshold

Fold too long line in Dockerfile

Decrease data loading interval seconds and fix typos

* Set default constructor and destructor

Comment exposed ports

Format commands

Increase number worker threads

Export ports of web server

Add build docker image bash

Fix nebula spec

Add package and build matrix test

Fix expose ports in docker compose yaml file

Upgrade new docker image and docker-compose deployment method

Mount local directory to container

Ignore docker data/logs folders

Restart on failure

* Move docker-compose configure file to other repo

vesoft/nebula-docker-compose

Fix docker image tag

* Use matrix of action to parallel jobs

* Update package script

Delete package type parameter for package script

Fix package errors

Source bash environment variables

Add BASH_ENV variable

Use absolute path for cmake and ctest

Add library path

Add nebula bin env variable

Test package

Test env variable for library path

Fix package project path error

Update env variables

Fix system check branch error

* Rename ci workflow file

* Fix package error

* Rename and cancel multithreads for ctest in CI

* Try test in singlethread and add tag release package trigger

* Fix uploaded artifacts name

Ignore docs path for build workflow

Use short commit sha when no version

Exact match

Add badge image link

Address comments of PR review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants