fix leader changed bug #137
Merged
+134
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veezhang
reviewed
Jun 6, 2022
pkg/nebula/meta_client.go
Outdated
| if execResp, ok := resp.(*meta.ExecResp); ok { | ||
| return execResp.Code | ||
| } | ||
| return reflect.ValueOf(resp).Elem().Field(0).Interface().(nebula.ErrorCode) |
There was a problem hiding this comment.
This seems puzzling, is there a better way?
pkg/nebula/meta_client.go
Outdated
| if execResp, ok := resp.(*meta.ExecResp); ok { | ||
| return execResp.Leader | ||
| } | ||
| return reflect.ValueOf(resp).Elem().Field(1).Interface().(*nebula.HostAddr) |
There was a problem hiding this comment.
Similar to the previous one.
| } | ||
|
|
||
| for _, space := range spaces { | ||
| if contains(nc.Status.Storaged.BalancedSpaces, *space.Id.SpaceID) { |
There was a problem hiding this comment.
Why not check the spaces every time?
Is it possible that the time between the two executions of this function is relatively long?
There was a problem hiding this comment.
A balanced space is not needed balance again.
| return nil | ||
| } | ||
| } | ||
| log.Info("Balance job in progress") | ||
| return &utilerrors.ReconcileError{Msg: fmt.Sprintf("Balance job %d still in progress", jobID)} | ||
| } | ||
|
|
||
| func (m *metaClient) retryOnError(req interface{}, fn ExecFn) error { | ||
| func (m *metaClient) retryOnError(req interface{}, fn Fn) (interface{}, error) { |
There was a problem hiding this comment.
How about ?
type (
ExecResp interface{
GetErrorCode() nebula.ErrorCode
GetChangedLeader() *nebula.HostAddr
}
ExecFn func(req interface{}) (ExecResp, error)
)
func (m *metaClient) retryOnError(req interface{}, fn ExecFn) error {
...
}
You can set the `resp` in `ExecFn` to avoid type conversions?There was a problem hiding this comment.
It's tedious, each method must define a wrapper to implement ExecResp. I prefer using reflect to get the response value.
|
@MegaByte875 could I know the behavoir of the bug that this PR is trying to fix, please? |
|
@wey-gu Yes, fix the leader change bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.