Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

Fix seek by negative vid #932

Merged
merged 3 commits into from
Apr 8, 2021
Merged

Fix seek by negative vid #932

merged 3 commits into from
Apr 8, 2021

Conversation

Aiee
Copy link
Contributor

@Aiee Aiee commented Apr 7, 2021

As title.

Fix https://jira.nebula-graph.io/browse/NG-522

(root@nebula) [nba_int]> MATCH (v) WHERE id(v) == -100 RETURN v;
+--------------------------------------+
| v                                    |
+--------------------------------------+
| (-100 :player{age: 32, name: "Tim"}) |
+--------------------------------------+
Got 1 rows (time spent 7222/7811 us)

@Aiee Aiee added ready-for-testing PR: ready for the CI test ready-for-review labels Apr 7, 2021
@Aiee Aiee requested review from jievince and yixinglu April 7, 2021 11:22
@Aiee Aiee added the bug Type: something is unexpected label Apr 7, 2021
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent

@Aiee Aiee requested a review from a team April 8, 2021 02:06
@yixinglu yixinglu requested review from czpmango and jude-zhu April 8, 2021 02:08
@yixinglu yixinglu merged commit e70c326 into vesoft-inc:master Apr 8, 2021
@Aiee Aiee deleted the fix-neg-vid branch April 8, 2021 03:19
jude-zhu pushed a commit to jude-zhu/nebula-graph that referenced this pull request Apr 8, 2021
* Fix seek by negtive vid

Fix typo

* Fix tck

(cherry picked from commit e70c326)
@Aiee Aiee restored the fix-neg-vid branch April 8, 2021 03:55
yixinglu added a commit that referenced this pull request Apr 8, 2021
* fix agg executor when input dataset is empty (#901)

add tck

fix tck

format

fix sum(null) test cases

format

(cherry picked from commit e8ad874)

* Fix match where agg check (#919)

add ut

add tck

Co-authored-by: jie.wang <38901892+jievince@users.noreply.github.com>
(cherry picked from commit e6cf4b2)

* Fix cluster getNeightborIter (#922)

* fix cluster getNeightborIter

* add test case

Co-authored-by: cpw <13495049+CPWstatic@users.noreply.github.com>
(cherry picked from commit 8063659)

* Fix seek by negative vid (#932)

* Fix seek by negtive vid

Fix typo

* Fix tck

(cherry picked from commit e70c326)

* Retry for queries related to schema modifications in CI (#849)

* Retry and wait job finish

* cleanup lookup test wait time

* Fix test failures

* Drop unused spaces

* Cleanup wait tag edge indexes ready function

* Fix cases

* Drop the created spaces

* Result should not contains

* Fix contains steps

* Rename include to contains

* Use more threads to run tests

* Fix typo

* Address ding's comments

* Rename to cmpType

* Try to replace wait

(cherry picked from commit 3c66147)

Co-authored-by: kyle.cao <kyle.cao@vesoft.com>
Co-authored-by: jimingquan <mingquan.ji@vesoft.com>
Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com>
Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>
@Aiee Aiee deleted the fix-neg-vid branch April 10, 2021 06:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Type: something is unexpected ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants