Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Euclidean div/mod from num-bigint #766

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Use Euclidean div/mod from num-bigint #766

merged 1 commit into from
Aug 25, 2023

Conversation

jaybosamiya
Copy link
Contributor

Now that the PR I had opened quite a while ago to num-bigint has been merged, we get to use these two functions from the library instead.

Now that rust-num/num-bigint#245 has been
merged, by updating the version of num-bigint used in Verus, we get to
remove our custom implementation of these two functions.
@jaybosamiya jaybosamiya requested a review from parno August 23, 2023 21:15
Copy link
Collaborator

@parno parno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- congrats on landing the change in num-bigint!

@jaybosamiya jaybosamiya merged commit d46d0c9 into main Aug 25, 2023
4 checks passed
@jaybosamiya jaybosamiya deleted the euclid-div-mod branch August 25, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants