plotting visual bug fixes#650
Merged
Merged
Conversation
Collaborator
mail4umar
commented
Jun 26, 2023
mail4umar
commented
- Added % sign on importance plot for matplotlib
- Added Y label for lift chart and cutoff curve in matplotlib
- Removed quotation marks for plotly density plot
- Added % sign on importance plot for matplotlib - Added Y label for lift chart and cutoff curve in matplotlib - Removed quotation marks for plotly density plot
applied black
mail4umar
added
Bug
oualib
suggested changes
Jun 27, 2023
| "height": 500, | ||
| "autosize": False, | ||
| "xaxis_title": self.layout["x_label"], | ||
| "xaxis_title": self.layout["x_label"][1:-1], |
Collaborator
There was a problem hiding this comment.
You should never use this kind of logic directly in the code. Imagine that the user passes a customised layout, you'll always retrieve the first and the last character.
Collaborator
Author
There was a problem hiding this comment.
Got it. Thanks for pointing out.
Updated it.
oualib
approved these changes
Jun 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.