Skip to content

Bugfix - For ML fit functions, the input relation was modifying the user indents #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mail4umar wants to merge 1 commit into from
Closed

Bugfix - For ML fit functions, the input relation was modifying the user indents #1356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions verticapy/machine_learning/vertica/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2351,7 +2351,7 @@ def fit(
if isinstance(input_relation, vDataFrame) or (id_column):
tmp_view = True
if isinstance(input_relation, vDataFrame):
self.input_relation = input_relation.current_relation()
self.input_relation = input_relation.current_relation(reindent=False)
else:
self.input_relation = input_relation
if self._is_native:
Expand Down Expand Up @@ -7834,7 +7834,7 @@ def fit(
if isinstance(input_relation, vDataFrame) or (id_column):
tmp_view = True
if isinstance(input_relation, vDataFrame):
self.input_relation = input_relation.current_relation()
self.input_relation = input_relation.current_relation(reindent=False)
else:
self.input_relation = input_relation
if self._model_type == "MCA":
Expand Down
2 changes: 1 addition & 1 deletion verticapy/machine_learning/vertica/neighbors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3198,7 +3198,7 @@ def fit(
self._is_already_stored(raise_error=True)
self.key_columns = quote_ident(key_columns)
if isinstance(input_relation, vDataFrame):
self.input_relation = input_relation.current_relation()
self.input_relation = input_relation.current_relation(reindent=False)
if not X:
X = input_relation.numcol()
else:
Expand Down
2 changes: 1 addition & 1 deletion verticapy/machine_learning/vertica/preprocessing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1019,7 +1019,7 @@ def fit(
if isinstance(input_relation, vDataFrame):
if isinstance(X, NoneType):
X = input_relation.get_columns()
self.input_relation = input_relation.current_relation()
self.input_relation = input_relation.current_relation(reindent=False)
else:
if isinstance(X, NoneType):
X = vDataFrame(input_relation).get_columns()
Expand Down
2 changes: 1 addition & 1 deletion verticapy/machine_learning/vertica/tsa/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ def fit(
if isinstance(input_relation, vDataFrame) and self._is_native:
tmp_view = True
if isinstance(input_relation, vDataFrame):
self.input_relation = input_relation.current_relation()
self.input_relation = input_relation.current_relation(reindent=False)
else:
self.input_relation = input_relation
relation = gen_tmp_name(
Expand Down
Loading