Remove universal props and use '.' for virtual props (SYN-9108) #4286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invisig0th
requested changes
Jun 11, 2025
| @@ -28,7 +28,7 @@ The Storm Reference documentation provides numerous examples of both abstract St | |||
|
|
|||
| - *<form>* refers to a form / node primary property, such as ``inet:fqdn``. | |||
| - *<valu>* refers to the value of a primary property, such as ``woot.com`` in ``inet:fqdn=woot.com``. | |||
| - *<prop>* refers to a node secondary property (including universal properties) such as ``inet:ip:asn`` or ``inet:ip.created``. | |||
| - *<prop>* refers to a node secondary property (including virtual properties) such as ``inet:ip:asn`` or ``inet:ip.created``. | |||
There was a problem hiding this comment.
the example given is a meta prop. should perhaps mention both virtual and metas here?
There was a problem hiding this comment.
Yeah I wasn't too sure the wording we wanted to use and how much we wanted to differentiate meta/virtual props in the docs.
Cisphyx
changed the base branch from
synapse-3xx
to
synapse-3xx-major-model-changes
Cisphyx
changed the base branch from
synapse-3xx-major-model-changes
to
synapse-3xx
Co-authored-by: vEpiphyte <epiphyte@vertex.link>
Cisphyx
changed the base branch from
synapse-3xx
to
synapse-3xx-major-model-changes
vEpiphyte
changed the base branch from
synapse-3xx-major-model-changes
to
synapse-3xx
vEpiphyte
changed the base branch from
synapse-3xx
to
synapse-3xx-major-model-changes
vEpiphyte
changed the base branch from
synapse-3xx-major-model-changes
to
synapse-3xx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also move
.createdto a "meta" prop