Add file streaming for uploads/downloads#2853
Draft
william746a wants to merge 1 commit intovert-x3:masterfrom
Draft
Add file streaming for uploads/downloads#2853william746a wants to merge 1 commit intovert-x3:masterfrom
william746a wants to merge 1 commit intovert-x3:masterfrom
Conversation
tsegismont
reviewed
Feb 10, 2026
Member
tsegismont
left a comment
There was a problem hiding this comment.
Thanks for sharing this, @william746a
I looked only at the vertx-web changes so far, and I would prefer to avoid all the changes in RoutingContext API.
While we had file upload related methods at the RoutingContext level for ages, we added the io.vertx.ext.web.RoutingContext#body in relatively recent versions of Vert.x. The new method to retrieve a streamed body file should be there imo.
Also, can you please split the PR into two commits to make it easier to review? One for the vertx-web changes and another for vertx-web-api? Thanks
Author
|
@tsegismont you got it, I'll get started on round 2 this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Explain here the context, and why you're making that change, what is the problem you're trying to solve.
Conformance:
You should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines