Check for fenced old leader in mounted test. #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aversecat
force-pushed
the
auke/utils_check_mounted_quorum_fenced
branch
from
08522e5 to
9da6eff
Compare
Collaborator
|
This needs work. |
aversecat
force-pushed
the
auke/utils_check_mounted_quorum_fenced
branch
from
9da6eff to
115ddb4
Compare
Contributor
Author
|
hmmm double free. reworking... |
aversecat
force-pushed
the
auke/utils_check_mounted_quorum_fenced
branch
from
115ddb4 to
a410ae8
Compare
aversecat
force-pushed
the
auke/utils_check_mounted_quorum_fenced
branch
2 times, most recently
from
ff0eacb to
5863e67
Compare
aversecat
force-pushed
the
auke/utils_check_mounted_quorum_fenced
branch
from
5863e67 to
e6501c7
Compare
The old mounted check only considered begin/end quorum data, and not whether the old leader that is now disconnected was fenced by a new quorum leader. Since this is the quaranteed case if the leader is disconnected forcefully, this check must account for this case, so that quorum slots can be modified if the node is permanently removed or replaced. Signed-off-by: Auke Kok <auke.kok@versity.com>
aversecat
force-pushed
the
auke/utils_check_mounted_quorum_fenced
branch
from
e6501c7 to
a87e92c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old mounted check only considered begin/end quorum data, and not whether the old leader that is now disconnected was fenced by a new quorum leader.
Since this is the quaranteed case if the leader is disconnected forcefully, this check must account for this case, so that quorum slots can be modified if the node is permanently removed or replaced.
Normally, remounting from the fenced node should clear this. But that may be unwanted, due to e.g. equipment failure, data collection, or otherwise.