Skip to content

test for filter url-encoding #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

test for filter url-encoding #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a20ae08
test for filter url-encoding
Apr 10, 2018
b026ca6
test for doubling double-quotes
Apr 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 69 additions & 0 deletions APIClient.Tests/QueryTests/UrlEncodingTester.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
using NUnit.Framework;

namespace VersionOne.SDK.APIClient.Tests.QueryTests
{
public class UrlEncodingTester : MetaTesterBase
{
protected override string MetaTestKeys => "UrlEncodingTester";

private IAssetType X => AssetType("X");
private IAttributeDefinition Y => X.GetAttributeDefinition("Y");

[Test] public void TokenTerms_are_encoded()
{
var query = new Query(X) {
Filter = new TokenTerm("Y='Fish & Chips'")
};
var url = new QueryURLBuilder(query).ToString();
Assert.AreEqual("Data/X?sel=&where=Y='Fish+%26+Chips'", url);
}

[Test] public void equal_FilterTerms_are_encoded()
{
var filter = new FilterTerm(Y);
filter.Equal("Fish & Chips");

var query = new Query(AssetType("X")) {
Filter = filter
};
var url = new QueryURLBuilder(query).ToString();
Assert.AreEqual("Data/X?sel=&where=X.Y='Fish+%26+Chips'", url);
}

[Test] public void exists_FilterTerms_are_encoded()
{
var filter = new FilterTerm(Y);
filter.Exists();

var query = new Query(AssetType("X")) {
Filter = filter
};
var url = new QueryURLBuilder(query).ToString();
Assert.AreEqual("Data/X?sel=&where=%2BX.Y", url);
}

[Test] public void single_quotes_are_doubled()
{
var filter = new FilterTerm(Y);
filter.Equal("quote ' this");

var query = new Query(AssetType("X")) {
Filter = filter
};
var url = new QueryURLBuilder(query).ToString();
Assert.AreEqual("Data/X?sel=&where=X.Y='quote+%27%27+this'", url);
}

[Test] public void double_quotes_are_doubled()
{
var filter = new FilterTerm(Y);
filter.Equal("quote \" this");

var query = new Query(AssetType("X")) {
Filter = filter
};
var url = new QueryURLBuilder(query).ToString();
Assert.AreEqual("Data/X?sel=&where=X.Y='quote+%22%22+this'", url);
}
}
}
12 changes: 12 additions & 0 deletions APIClient.Tests/TestData.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,18 @@
</Response>
</Test>

<Test name="UrlEncodingTester">
<Response path="meta.v1/X">
<AssetType href="/v1.six/meta.v1/X" version="6.5.55555.30353" name="X" token="X" displayname="AssetType'X" abstract="False">
<DefaultOrderBy href="/v1.six/meta.v1/X/Y" tokenref="X.Y" />
<DefaultDisplayBy href="/v1.six/meta.v1/X/Y" tokenref="X.Y" />
<AttributeDefinition name="Y" token="X.Y" displayname="AttributeDefinition'Y'X" attributetype="Text" isreadonly="False" isrequired="False" ismultivalue="False">
<OrderByAttribute href="/v1.six/meta.v1/X/Y" tokenref="X.Y" />
</AttributeDefinition>
</AssetType>
</Response>
</Test>

<Test name="ServicesTester">
<Response path="meta.v1/Story">
<AssetType href="/v1.six/meta.v1/Story" version="6.5.55555.30353" name="Story" token="Story" displayname="AssetType'Story" abstract="False">
Expand Down
1 change: 1 addition & 0 deletions APIClient.Tests/VersionOne.SDK.APIClient.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@
<Compile Include="ConnectorTests\V1ConnectorTester.cs" />
<Compile Include="QueryTests\PagingTester.cs" />
<Compile Include="QueryTests\QueryFilter2Tester.cs" />
<Compile Include="QueryTests\UrlEncodingTester.cs" />
<Compile Include="ResponseConnector.cs" />
<Compile Include="ServicesTests\Constructor\When_preLoadMeta_is_false.cs" />
<Compile Include="ServicesTests\MetaSamplePayloads.cs" />
Expand Down