Skip to content

Scope for code optimization #62

@mghildiy

Description

@mghildiy

Hi,

In render.js:

Inside for loop in ParticleSystemBatcher.prototype.push

var x = p.position[0] * lasBuffer.scale[0] + lasBuffer.offset[0];
Later on:
positions[ 3*i ] = p.position[0] * lasBuffer.scale[0] + (lasBuffer.offset[0] - this.corrective.x);
This is same as:
positions[ 3*i ] = x - this.corrective.x

Similar for y and z coordinates.

With huge number of points, avoiding this recomputation may help in improving the performance.

PS:If permitted, I can commit this change.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions