Update testing dependencies #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakeane
force-pushed
the
jackkeane/update-static-test-versions
branch
from
5560e4a to
e2efd31
Compare
jakeane
commented
Sep 9, 2025
Collaborator
Author
jakeane
left a comment
jakeane
left a comment
There was a problem hiding this comment.
None linting changes here. Should not cause any changes to existing logic
Comment on lines
-50
to
+59
| assert issubclass(value, BaseModel), "invalid `pydantic.BaseModel`" | ||
| self.code_models[key] = value | ||
| if self.is_list_type(value): | ||
| assert issubclass( | ||
| value.__args__[0], BaseModel | ||
| ), "invalid `pydantic.BaseModel`" | ||
| self.code_models[key] = value.__args__[0] | ||
| else: | ||
| assert issubclass( | ||
| value, BaseModel | ||
| ), "invalid `pydantic.BaseModel`" | ||
| self.code_models[key] = value |
Collaborator
Author
There was a problem hiding this comment.
Add handling for list types, following pattern from source repository.
Comment on lines
-53
to
+61
| elif issubclass(request_body, BaseModel): | ||
| result = Request(request_body).generate_spec() | ||
| else: | ||
| result = {} | ||
| try: | ||
| if issubclass(request_body, BaseModel): | ||
| result = Request(request_body).generate_spec() | ||
| else: | ||
| result = {} | ||
| except TypeError: | ||
| # request_body is not a class (e.g., generic type) | ||
| result = {} |
Collaborator
Author
There was a problem hiding this comment.
Add defensive handling for generic types, following source repository logic
Comment on lines
-2
to
+8
| openapi-spec-validator>=0.2.9, <0.3 | ||
| pytest==7.1.2 | ||
| flake8>=4.0.1, <5 | ||
| flask==2.2.5 | ||
| werkzeug==2.2.3 | ||
| requests==2.31.0 | ||
| black==22.3.0 | ||
| mypy==0.971 | ||
| openapi-spec-validator == 0.7.1 | ||
| pytest>=8.3.5, <9 | ||
| flake8 == 7.1.1 | ||
| flask>=2.0.2, <3 | ||
| requests>=2.24.0, <3 | ||
| black>=20.8b1 | ||
| mypy==1.10.0 |
Collaborator
Author
There was a problem hiding this comment.
Updates to match source repository
Comment on lines
-7
to
+8
| from openapi_spec_validator import validate_v3_spec | ||
| from pydantic.v1 import BaseModel, Field, StrictFloat | ||
| from openapi_spec_validator import OpenAPIV30SpecValidator | ||
| from pydantic.v1 import BaseModel, StrictFloat, Field |
Collaborator
Author
There was a problem hiding this comment.
Tests updated to handle dependency updates
jakeane
changed the title
CharlesLiu02
approved these changes
Sep 9, 2025
CharlesLiu02
left a comment
CharlesLiu02
left a comment
There was a problem hiding this comment.
Not familiar with the flask pydantic spec logic changes, but will stamp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the testing dependencies to match source repository. The prior dependencies became stale, causing CI to break. There are some minor updates to application logic, which were done in line with the source repository, but it should not cause any change in behavior.