[Packer] Fixed NightlyTest Failure with Tight Floorplan Constr. #3178
+16
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The very tight floorplan constraints were failing after the recent changes to the iterative packing algorithm. After investigation I found that there is a bug with unrelated clustering and RAMs which is causing floorplan constraints to not be adhered to. The original code ignored this issue by not doing unrelated clustering when there are floorplan constraints. To fix this issue, reimplemented what the code was originally doing to allow this testcase to proceed. This just moves the unrelated clustering to after trying all floorplan region options.
github-actions
bot
added
VPR
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The very tight floorplan constraints were failing after the recent changes to the iterative packing algorithm. After investigation I found that there is a bug with unrelated clustering and RAMs which is causing floorplan constraints to not be adhered to. The original code ignored this issue by not doing unrelated clustering when there are floorplan constraints.
To fix this issue, reimplemented what the code was originally doing to allow this testcase to proceed. This just moves the unrelated clustering to after trying all floorplan region options.