parameterized class module parameters #6754 #6834
Draft
+542
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed at the end of #6754 I ended up piggybacking on the 'interface capture' work/PR that I had worked on before (this went a bit smoother than I anticipated). At a high level this means:
This also has the happy consequence of solving a nested class issue that I opened a couple years ago... It was "Unlinked when getting bit width of type defined in parameterized class #4391". Added the test from that issue as t_mod_param_class_typedef7.v/py.
@wsnyder keeping this as draft if you can take an early look and see if you are ok with the direction and then I will finish cleaning it up. One thought I had was to now rename the V3LinkDotIfaceCapture to something like V3LinkDotDeferredCapture or something similar as it would now handle nested typedef deferrals for both interfaces and class.