chore: update material-ui@4.x

[juanpicado]

Type: build

Description:

We migrate constantly to the latest libraries, before this get old we need to address it, to consider this done, all test must pass, linting should works and trying to minimize refactoring as much as possible.

https://material-ui.com/guides/migration-v3/

• Fix linting
• Fix Unit Test
• Something else still I'm not aware 🤔

Open Questions

• Does it require complete refactoring? Yes / No
• It works with enzyme, at least mount? Yes / No According this, yes it does Test custom async hooks enzymejs/enzyme#2012 (comment) , at this moment.
• emotion friendly? Yes / No
• Does we want to use @testing-library/react for components with no state, no events, no test full render required? Yes / No
• Does Material-UI is 100% Enzyme incompatible 🤔 ? Yes / No

Aims to Resolves #87

References

• https://material-ui.com/r/caveat-with-refs-guide
• enzyme.simulate() is deprecated Deprecation of .simulate() enzymejs/enzyme#2173 (comment)

Posible blockers

• Enzyme and hooks React hooks support checklist enzymejs/enzyme#2011
  • useEffect and useLayoutEffect not works with shallow because react shallow renderer doesn't run it. React hooks support checklist enzymejs/enzyme#2011
  • useCallback doesn't memoize callback in react shallow renderer useCallback doesn't memoize callback in shallow renderer facebook/react#15774
  • Basic hooks support [Tests] add hooks tests enzymejs/enzyme#2008
  • .dive() doesn't work well with component using useContext() .dive() doesn't work well with component using useContext() enzymejs/enzyme#2165
  • [Shallow] Implement callEffects option to call effects from shallow renderer (#15275) [Shallow] Implement callEffects option to call effects from shallow renderer (#15275) facebook/react#16168 -> Interesting comment ([Shallow] Implement callEffects option to call effects from shallow renderer (#15275) facebook/react#16168 (comment)) ⚠️ no clear answer wether this will be accepted yet.

Take Aways

• react hooks and jest.doMock does not play well yet.
• Migrate current test is easy, just avoid the first point and use mount
• Using mount requires update snapshots.
• Minor changes on Material-UI styles
• Breaking changes did not affect us too much.
• Some "errors" and warnings still remains, but will disappear as long we migrate to hooks https://github.com/verdaccio/ui/issues/116

[codecov-io]

Codecov Report

Merging #123 into master will decrease coverage by 0.65%.
The diff coverage is 85%.

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
- Coverage    84.9%   84.25%   -0.66%     
==========================================
  Files          92       92              
  Lines         888      902      +14     
  Branches      157      160       +3     
==========================================
+ Hits          754      760       +6     
- Misses        116      126      +10     
+ Partials       18       16       -2

Impacted Files	Coverage Δ
src/components/DetailSidebar/DetailSidebar.tsx	100% <ø> (ø)	⬆️
src/components/Header/Header.tsx	89.47% <ø> (ø)	⬆️
src/components/Repository/Repository.tsx	100% <ø> (ø)	⬆️
src/components/Dist/Dist.tsx	100% <ø> (ø)	⬆️
src/components/Help/Help.tsx	100% <ø> (ø)	⬆️
src/components/UpLinks/UpLinks.tsx	30% <ø> (ø)	⬆️
src/components/Package/Package.tsx	100% <ø> (ø)	⬆️
src/components/Versions/Versions.tsx	66.66% <ø> (-8.34%)	⬇️
src/components/Engines/Engines.tsx	100% <ø> (ø)	⬆️
src/components/Developers/Developers.tsx	100% <ø> (ø)	⬆️
... and 10 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 376b84f...b0049a6. Read the comment docs.

[juanpicado]

Bundle size

main goes from main (731 KiB) to main (657 KiB).
vendor goes from vendor (598 KiB) to vendor (527 KiB).

Hash: afdbdf6d37b07cde3149
Version: webpack 4.39.3
Time: 27773ms
Built at: 08/31/2019 10:49:17 AM
                               Asset       Size  Chunks                    Chunk Names
    0.style.2ea8a5d1276179958242.css   4.95 KiB       0  [emitted]         vendors
           1.afdbdf6d37b07cde3149.js   27.8 KiB       1  [emitted]         
1f07aa4bad48cd09088966736d1ed121.svg   1.73 KiB          [emitted]         
    2.style.92647ec0a7beb8b2898d.css  151 bytes       2  [emitted]         main
24fd3a77ee5710ead382075bbfa36d17.svg  380 bytes          [emitted]         
2939f26c293bff8f35ba87194742aea8.png   26.9 KiB          [emitted]         
3025c327f6f127d5190f14b16e75b41b.svg  851 bytes          [emitted]         
           4.afdbdf6d37b07cde3149.js    105 KiB       4  [emitted]         
4743f1431b042843890a8644e89bb852.svg  802 bytes          [emitted]         
           5.afdbdf6d37b07cde3149.js   21.8 KiB       5  [emitted]         
           6.afdbdf6d37b07cde3149.js   28.2 KiB       6  [emitted]         
    6.style.f5bfe8c872c998c962a0.css   14.6 KiB       6  [emitted]         
6f6560222974090c1ef11e84623ff803.svg   1.73 KiB          [emitted]         
           7.afdbdf6d37b07cde3149.js   6.26 KiB       7  [emitted]         
728ff5a8e44d74cd0f2359ef0a9ec88a.png   2.33 KiB          [emitted]         
78c8b4a1d574ed616610e18b2c855e0c.svg  321 bytes          [emitted]         
7d79cfa41d195ac7ae3ad9064741f1a2.svg  344 bytes          [emitted]         
81ca2d852b9bc86713fe993bf5c7104c.svg   1.74 KiB          [emitted]         
93df1ce974e744e7d98f5d842da74ba0.svg   1.94 KiB          [emitted]         
a154dffa8c64411bb7877a3e5160d4cc.svg  464 bytes          [emitted]         
ac0877b3e5dab78d7b5319b32cb03b11.svg  833 bytes          [emitted]         
ae4c5ae3eda00b36688ee6530e12e81e.svg  265 bytes          [emitted]         
b1e0d4d4ee23474aee6616f444fc7aa9.svg   2.08 KiB          [emitted]         
d96f386211a24e791aaa1f929fd56f91.svg   2.99 KiB          [emitted]         
d97aee5956d22e8a5cb8a05f49d749e8.svg   1.76 KiB          [emitted]         
de092a6cac20ccf2cd373644425a13ce.svg   1.34 KiB          [emitted]         
dfa6f8e42f5b37f73d24dea250e744b5.svg  977 bytes          [emitted]         
e34a1f287ed2e5ca2d2fa0e0922cddfb.svg   1.21 KiB          [emitted]         
fa99a58eb30e323243a5b2dbae7eacdd.svg  898 bytes          [emitted]         
                         favicon.ico   14.7 KiB          [emitted]         
         fonts/roboto-latin-100.woff   19.9 KiB          [emitted]         
        fonts/roboto-latin-100.woff2   15.4 KiB          [emitted]         
   fonts/roboto-latin-100italic.woff   21.2 KiB          [emitted]         
  fonts/roboto-latin-100italic.woff2   16.6 KiB          [emitted]         
         fonts/roboto-latin-300.woff   19.9 KiB          [emitted]         
        fonts/roboto-latin-300.woff2   15.4 KiB          [emitted]         
   fonts/roboto-latin-300italic.woff   21.7 KiB          [emitted]         
  fonts/roboto-latin-300italic.woff2     17 KiB          [emitted]         
         fonts/roboto-latin-400.woff   19.8 KiB          [emitted]         
        fonts/roboto-latin-400.woff2   15.4 KiB          [emitted]         
   fonts/roboto-latin-400italic.woff   21.4 KiB          [emitted]         
  fonts/roboto-latin-400italic.woff2   16.9 KiB          [emitted]         
         fonts/roboto-latin-500.woff     20 KiB          [emitted]         
        fonts/roboto-latin-500.woff2   15.5 KiB          [emitted]         
   fonts/roboto-latin-500italic.woff   21.5 KiB          [emitted]         
  fonts/roboto-latin-500italic.woff2   16.9 KiB          [emitted]         
         fonts/roboto-latin-700.woff   19.9 KiB          [emitted]         
        fonts/roboto-latin-700.woff2   15.4 KiB          [emitted]         
   fonts/roboto-latin-700italic.woff   21.1 KiB          [emitted]         
  fonts/roboto-latin-700italic.woff2   16.6 KiB          [emitted]         
         fonts/roboto-latin-900.woff   19.9 KiB          [emitted]         
        fonts/roboto-latin-900.woff2   15.3 KiB          [emitted]         
   fonts/roboto-latin-900italic.woff   21.8 KiB          [emitted]         
  fonts/roboto-latin-900italic.woff2   17.1 KiB          [emitted]         
                          index.html   1.26 KiB          [emitted]         
        main.afdbdf6d37b07cde3149.js    121 KiB       2  [emitted]         main
    manifest.afdbdf6d37b07cde3149.js   3.31 KiB       3  [emitted]         manifest
     vendors.afdbdf6d37b07cde3149.js    527 KiB       0  [emitted]  [big]  vendors
Entrypoint main [big] = manifest.afdbdf6d37b07cde3149.js 0.style.2ea8a5d1276179958242.css vendors.afdbdf6d37b07cde3149.js 2.style.92647ec0a7beb8b2898d.css main.afdbdf6d37b07cde3149.js
 [10] (webpack)/buildin/harmony-module.js 573 bytes {0} [built]
 [18] ./src/utils/styles/colors.ts 1.6 KiB {2} [built]
 [40] ./node_modules/history/esm/history.js + 3 modules 31 KiB {0} [built]
      |    4 modules
 [74] ./src/utils/storage.ts 1.13 KiB {2} [built]
 [79] ./src/utils/api.ts 4.62 KiB {2} [built]
 [86] (webpack)/buildin/global.js 472 bytes {0} [built]
[109] ./src/App/App.tsx 9.95 KiB {2} [built]
[199] ./src/utils/login.ts 3.82 KiB {2} [built]
[280] ./src/App/index.ts 173 bytes {2} [built]
[309] ./src/router.tsx 5.58 KiB {2} [built]
[353] multi babel-polyfill whatwg-fetch ./src/index.tsx 52 bytes {2} [built]
[557] ./src/index.tsx 1.36 KiB {2} [built]
[558] ./src/utils/__setPublicPath__.ts 305 bytes {2} [built]
[617] ./src/styles/typeface-roboto.css 39 bytes {2} [built]
[618] ./src/utils/styles/global.ts 2.07 KiB {2} [built]
    + 830 hidden modules

WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
This can impact web performance.
Assets: 
  vendors.afdbdf6d37b07cde3149.js (527 KiB)

WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance.
Entrypoints:
  main (657 KiB)
      manifest.afdbdf6d37b07cde3149.js
      0.style.2ea8a5d1276179958242.css
      vendors.afdbdf6d37b07cde3149.js
      2.style.92647ec0a7beb8b2898d.css
      main.afdbdf6d37b07cde3149.js

✨  Done in 34.42s.