workflow: stub workflow/api package so it can be referenced in a workflow context #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: eccd473 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Schniz
force-pushed
the
schniz/stub-workflow-api-package
branch
from
fb54558 to
77f015c
Compare
…flow context what's not allowed is to call these functions, so let's stub them and make them fail in runtime. i guess that eventually we will actually implement some of them (start or resumeHook or whatever) in a durable way. Signed-off-by: Gal Schlezinger <gal@spitfire.co.il>
Schniz
force-pushed
the
schniz/stub-workflow-api-package
branch
from
77f015c to
ee3d29e
Compare
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🔧 Build Fix:
The runId parameter in the Run class constructor is declared but never used, causing a TypeScript error TS6133.
View Details
📝 Patch Details
diff --git a/packages/workflow/src/api-workflow.ts b/packages/workflow/src/api-workflow.ts
index a54c381..c2f4d26 100644
--- a/packages/workflow/src/api-workflow.ts
+++ b/packages/workflow/src/api-workflow.ts
@@ -12,7 +12,7 @@ const workflowStub = (item: string) => {
};
export class Run {
- constructor(runId?: string) {
+ constructor(_runId?: string) {
workflowStub('Run');
}
}
Analysis
TypeScript unused parameter error in Run constructor
What fails: TypeScript compiler fails on packages/workflow/src/api-workflow.ts line 15 due to unused parameter runId in Run class constructor
How to reproduce:
cd packages/workflow && pnpm run buildResult:
src/api-workflow.ts(15,15): error TS6133: 'runId' is declared but its value is never read.
Schniz
force-pushed
the
schniz/stub-workflow-api-package
branch
from
cedbade to
2c4eb65
Compare
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com> Signed-off-by: Gal Schlezinger <gal@spitfire.co.il>
Schniz
force-pushed
the
schniz/stub-workflow-api-package
branch
from
2c4eb65 to
eccd473
Compare
TooTallNate
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what's not allowed is to call these functions, so let's stub them and make them fail in runtime.
i guess that eventually we will actually implement some of them (start or resumeHook or whatever) in a durable way.