[next] Image Optimization for default loader #5321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
ijjk
approved these changes
Oct 24, 2020
timneutkens
approved these changes
Oct 24, 2020
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Oct 25, 2020
We currently always accept requests to the new `/_next/image` endpoint, even when it should not be used. Instead, we should check to see if the default loader is used as a signal to enable this API. Other loaders (such as cloudinary) will not go through the Next.js API so there is no need to expose this, instead we 404. - Analogous to vercel/vercel#5321 - Related to #18122
This was referenced Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently pass through
imageswhenever its defined, but this is enabling Image Optimization in the Proxy for every Next.js project.Instead, we should check to see if the default loader is used (the same use for
next dev) as a signal to enable this feature in the deployment.Related to vercel/next.js#18122