Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use vc token if logging into Vercel #7174

Merged
merged 1 commit into from
Feb 7, 2024
Merged

use vc token if logging into Vercel #7174

merged 1 commit into from
Feb 7, 2024

Conversation

Zertsov
Copy link
Contributor

@Zertsov Zertsov commented Jan 30, 2024 •
edited
Loading

Description

If users are logging into Vercel, we should allow for them to use an existing Vercel CLI token if it exists. This is only for non-SSO logins. SSO will follow in another PR.

Testing Instructions

  1. Use vc login to get a Vercel token. Do not use SSO (this doesn't implement that yet).
  2. Make sure you don't have a turbo token by running turbo logout.
  3. Run turbo login - you should see a message saying Existing Vercel token found!
  4. Run turbo link on a repo you have access to in Vercel
  5. Try running a cacheable task. You should see that remote caching is enabled.

Closes TURBO-2194

@vercel Vercel
Copy link

vercel bot commented Jan 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-gatsby-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 7, 2024 5:23pm
examples-kitchensink-blog 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 7, 2024 5:23pm
rust-docs ❌ Failed (Inspect) Feb 7, 2024 5:23pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2024 5:23pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2024 5:23pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2024 5:23pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2024 5:23pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2024 5:23pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2024 5:23pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2024 5:23pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2024 5:23pm

@Zertsov Graphite App
Copy link
Contributor Author

Zertsov commented Jan 30, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Zertsov and the rest of your teammates on Graphite Graphite

@Zertsov Zertsov mentioned this pull request Jan 30, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2024 •
edited
Loading

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2024 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@Zertsov Zertsov marked this pull request as ready for review January 30, 2024 22:06
@Zertsov Zertsov requested a review from a team as a code owner January 30, 2024 22:06
@Zertsov Zertsov requested review from chris-olszewski and NicholasLYang and removed request for a team January 30, 2024 22:06
@Zertsov Zertsov force-pushed the voz/reuse-vercel-token branch from f2e4da3 to 5ae26bc Compare January 30, 2024 22:44
@Zertsov Zertsov force-pushed the voz/reuse-vercel-token branch from 5ae26bc to 023487e Compare January 31, 2024 16:10
@Zertsov Zertsov force-pushed the voz/reuse-vercel-token branch from 023487e to 68e5cdb Compare January 31, 2024 16:18
@Zertsov Zertsov mentioned this pull request Jan 31, 2024
Merged
@Zertsov Zertsov force-pushed the voz/reuse-vercel-token branch from 68e5cdb to 8469bdc Compare January 31, 2024 16:42
@Zertsov Zertsov force-pushed the voz/reuse-vercel-token branch from 059e5ce to a5d2db8 Compare February 5, 2024 21:25
@Zertsov Zertsov force-pushed the voz/reuse-vercel-token branch from a5d2db8 to 45bdd21 Compare February 6, 2024 16:57
@Zertsov Zertsov requested a review from a team as a code owner February 6, 2024 16:57
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024

✅ This change can build next-swc

@Zertsov Zertsov force-pushed the voz/reuse-vercel-token branch from 45bdd21 to dd364be Compare February 6, 2024 18:45
@Zertsov Zertsov force-pushed the voz/reuse-vercel-token branch from dd364be to 993c361 Compare February 6, 2024 19:23
@Zertsov Zertsov force-pushed the voz/reuse-vercel-token branch from 993c361 to 8eb965f Compare February 6, 2024 22:06
@Zertsov Zertsov force-pushed the voz/reuse-vercel-token branch from 8eb965f to 9bc3c01 Compare February 6, 2024 23:15
@Zertsov Zertsov force-pushed the voz/reuse-vercel-token branch from 9bc3c01 to 78fe24c Compare February 6, 2024 23:57
@Zertsov Zertsov force-pushed the voz/reuse-vercel-token branch from 78fe24c to f1ea261 Compare February 7, 2024 00:01
@Zertsov Zertsov force-pushed the voz/reuse-vercel-token branch from f1ea261 to 4a2cca5 Compare February 7, 2024 00:51
@Zertsov Zertsov force-pushed the voz/reuse-vercel-token branch from 4a2cca5 to 7b88e9d Compare February 7, 2024 16:11
@Zertsov Zertsov force-pushed the voz/reuse-vercel-token branch from 7b88e9d to cebcb66 Compare February 7, 2024 17:21
@Zertsov Zertsov merged commit 47f5b97 into main Feb 7, 2024
@Zertsov Zertsov deleted the voz/reuse-vercel-token branch February 7, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-olszewski chris-olszewski chris-olszewski approved these changes

@NicholasLYang NicholasLYang Awaiting requested review from NicholasLYang NicholasLYang is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
area: ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zertsov @chris-olszewski