Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(launch): update vscode launch configs #6887

Merged
merged 1 commit into from
Jan 4, 2024
Merged

feat(launch): update vscode launch configs #6887

merged 1 commit into from
Jan 4, 2024

Conversation

tknickman
Copy link
Member

@tknickman tknickman commented Jan 4, 2024 •
edited by padmaia
Loading

Description

Update the vscode launch configs

  1. Update the version to get access to user input and grouping
  2. Remove old Go and e2e configs
  3. Fix the existing configs to user skip-infer to ensure we're using the local built turbo and not the one installed in the example
  4. Cleans up unused actions

Closes TURBO-1991

@tknickman tknickman requested review from a team as code owners January 4, 2024 16:37
@vercel Vercel
Copy link

vercel bot commented Jan 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

11 Ignored Deployments
Name Status Preview Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Jan 4, 2024 4:37pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Jan 4, 2024 4:37pm
examples-gatsby-web ⬜️ Ignored (Inspect) Jan 4, 2024 4:37pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jan 4, 2024 4:37pm
examples-native-web ⬜️ Ignored (Inspect) Jan 4, 2024 4:37pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Jan 4, 2024 4:37pm
examples-svelte-web ⬜️ Ignored (Inspect) Jan 4, 2024 4:37pm
examples-tailwind-web ⬜️ Ignored (Inspect) Jan 4, 2024 4:37pm
examples-vite-web ⬜️ Ignored (Inspect) Jan 4, 2024 4:37pm
rust-docs ⬜️ Ignored (Inspect) Jan 4, 2024 4:37pm
turbo-site ⬜️ Ignored (Inspect) Jan 4, 2024 4:37pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024 •
edited
Loading

🟢 CI successful 🟢

Thanks

@tknickman tknickman enabled auto-merge (squash) January 4, 2024 17:06
chris-olszewski
chris-olszewski approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reminding me that we can easily use the debugger now that we're full Rust.

@tknickman tknickman merged commit deed498 into main Jan 4, 2024
41 checks passed
@tknickman tknickman deleted the update-launch-configs branch January 4, 2024 20:00
Zertsov pushed a commit that referenced this pull request Jan 5, 2024
@tknickman @Zertsov
feat(launch): update vscode launch configs (#6887)
b0d09b1 
### Description

Update the vscode launch configs

1. Update the version to get access to user input and grouping
2. Remove old Go and e2e configs
3. Fix the existing configs to user skip-infer to ensure we're using the
local built turbo and not the one installed in the example
4. Cleans up unused actions

Closes TURBO-1991
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-olszewski chris-olszewski chris-olszewski approved these changes

@gsoltis gsoltis Awaiting requested review from gsoltis gsoltis is a code owner automatically assigned from vercel/turbo-oss

@NicholasLYang NicholasLYang Awaiting requested review from NicholasLYang NicholasLYang is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tknickman @chris-olszewski