perf: Pre-compile dependencies to reduce install size/time #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
changed the title
ijjk
requested review from
huozhi,
styfle and
timneutkens
and removed request for
giuseppeg
|
We might can also get rid of the warning of styled-jsx when install next.js, since babel plugin is not a dep anymore |
|
🎉 This PR is included in version 5.0.0-beta.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Jan 17, 2022
This ncc's some remaining dependencies bringing us under 20 install time dependencies (including nested dependencies), this also reduces install size by another `2.75 MB`. A follow-up PR will investigate a custom install script for our swc packages to allow us to remove the `optionalDependencies` which is slowing down install time as well. x-ref: #32679 x-ref: #32627 x-ref: #31887 x-ref: vercel/styled-jsx#770
huozhi
pushed a commit
that referenced
this pull request
Jan 20, 2022
natew
pushed a commit
to natew/next.js
that referenced
this pull request
Feb 16, 2022
This ncc's some remaining dependencies bringing us under 20 install time dependencies (including nested dependencies), this also reduces install size by another `2.75 MB`. A follow-up PR will investigate a custom install script for our swc packages to allow us to remove the `optionalDependencies` which is slowing down install time as well. x-ref: vercel#32679 x-ref: vercel#32627 x-ref: vercel#31887 x-ref: vercel/styled-jsx#770
nevilm-lt
pushed a commit
to nevilm-lt/next.js
that referenced
this pull request
Apr 22, 2022
This ncc's some remaining dependencies bringing us under 20 install time dependencies (including nested dependencies), this also reduces install size by another `2.75 MB`. A follow-up PR will investigate a custom install script for our swc packages to allow us to remove the `optionalDependencies` which is slowing down install time as well. x-ref: vercel#32679 x-ref: vercel#32627 x-ref: vercel#31887 x-ref: vercel/styled-jsx#770
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all dependencies to
devDependenciesby pre-compiling withnccto reduce the install size and time.Before:
2.5M styled-jsx-pre-ncc/node_modulesAfter:
904K styled-jsx-post-ncc/node_modulesThis removes 17 nested dependencies.
x-ref: vercel/next.js#32742