Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade example to Svelte 5 / SvelteKit 2 (Fixes #77) #78

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

skve
Copy link
Contributor

@skve skve commented Oct 22, 2024

📓 What's in there?

Installation is currently broken on a fresh Next.js repo because speed-analytics relies on an outdated version of Svelte.

🧪 How to test?

  • Run pnpm dev in apps/sveltekit
    • Observe it works as before

-->

Signed-off-by: Luke Shiels <47612057+skve@users.noreply.github.com>
Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
speed-insights-astro ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 6:16am
speed-insights-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 6:16am
speed-insights-nuxt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 6:16am
speed-insights-remix ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 6:16am
speed-insights-sveltekit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 6:16am
speed-insights-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 6:16am

Copy link
Collaborator

@tobiaslins tobiaslins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:thank-u: !

I just changed the svelte peerDependency to be >= 4 so its not only compatible with svelte 5

@feugy feugy merged commit 7fa98c6 into vercel:main Oct 22, 2024
11 checks passed
@skve skve deleted the fix-svelte-dependencies branch October 22, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants