Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding symlinks to schema. Resolves zeit/serve#519 #53

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

jolyndenning
Copy link
Contributor

@jolyndenning
Copy link
Contributor Author

any update on this?

@jolyndenning
Copy link
Contributor Author

any update?

1 similar comment
@jolyndenning
Copy link
Contributor Author

any update?

@dariusbakunas
Copy link

For those looking for a temporary fix, I had some success with using patch utility to apply this patch after serve is installed:

diff --git a/node_modules/@zeit/schemas/deployment/config-static.js b/node_modules/@zeit/schemas/deployment/config-static.js
index 55cff95..7e713c5 100644
--- a/node_modules/@zeit/schemas/deployment/config-static.js
+++ b/node_modules/@zeit/schemas/deployment/config-static.js
@@ -73,6 +73,9 @@ module.exports = {
 		},
 		'renderSingle': {
 			type: 'boolean'
+		},
+		'symlinks': {
+			type: 'boolean'
 		}
 	},
 	additionalProperties: false

save this file as @zeit+schemas+2.6.0.patch and then patch command like so:

% patch -p1 -d /usr/local/share/.config/yarn/global < @zeit+schemas+2.6.0.patch

Note: I am using yarn to install serve globally, so your node_modules location might be different

Or there is also https://www.npmjs.com/package/patch-package that could apply the same patch in postinstall step (that is if you don't install serve globally)

@trusktr
Copy link

trusktr commented Aug 27, 2021

Still not merged? Seriously?

@jolyndenning
Copy link
Contributor Author

I don't represent vercel but do not think it's helpful to express anger or sarcasm over this. This is an open source project and the maintainers of it owe us nothing.

@Dinhero21
Copy link

4 years later and it still hasn't been merged?

@Johennes
Copy link

@AndyBitz maybe you could help with this?

Copy link
Contributor

@AndyBitz AndyBitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I'll tend to it.

@AndyBitz AndyBitz merged commit 554e6c7 into vercel:main Apr 25, 2024
2 checks passed
@Johennes
Copy link

Thank you! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants