Conversation
request and then-sleeprequest and then-sleep dependencies
ijjk
reviewed
Aug 18, 2019
leo
suggested changes
Aug 19, 2019
Contributor
leo
left a comment
There was a problem hiding this comment.
I don't think we should maintain our own code path for promise sleeping. That's what npm packages exist for.
|
@leo if the one liner was published as an npm module, would that be acceptable? Currently then-sleep adds 37 dependencies for something that can be published as a single line 😬 |
Contributor
@bnb Absolutely! That's what I thought we'd get. 🙏 |
leo
approved these changes
Aug 27, 2019
Member
Author
|
Fixed in 6.1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes
requesttonode-fetch.And also
then-sleepto a one-line functionsleep.Resolves out of date dependencies brought up by @bnb upon npm install.