Skip to content

Fix Stuck on "Opening GitHub authentication page"#152

Merged
styfle merged 1 commit intovercel:masterfrom
ijjk:fix-stall-on-open
Mar 1, 2019
Merged

Fix Stuck on "Opening GitHub authentication page"#152
styfle merged 1 commit intovercel:masterfrom
ijjk:fix-stall-on-open

Conversation

@ijjk
Copy link
Member

@ijjk ijjk commented Feb 26, 2019

Updated to not wait for open since it sometimes doesn't resolve until the browser is completely closed i.e. cmd + q on Mac

Fixes: #151

browser is completely closed ie cmd + q on Mac
@styfle
Copy link
Member

styfle commented Feb 28, 2019

Related issue: sindresorhus/open#91

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not ideal but it works! 👍

Thanks for fixing this! 🎉

@styfle styfle merged commit fdfb10c into vercel:master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stuck on "Opening GitHub authentication page"

2 participants