This repository has been archived by the owner on Jan 21, 2023. It is now read-only.
Update broken readme tweet banner #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/og-image/czkhempgc |
|
This is how it looks of now 👇 |
styfle
reviewed
Aug 14, 2020
noahflk
pushed a commit
to noahflk/og-image
that referenced
this pull request
Apr 15, 2021
* fix: update dead readme banner * Update link Co-authored-by: Steven <steven@ceriously.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, thanks for this amazing project! 💯
Issues
I just saw the currently embedded tweet image in the readme is broken, on all browsers and it seems to look terrible on some, as shown below.
Mozilla Firefox
Microsoft Edge
Fixes
So, I updated the src link of the image to the correct path.
And also I searched for the actual tweet on Twitter as the current href link of the
atag also seems to be broken as no tweet is available with that id.So, I linked the href to the official vercel account on twitter
Hope, this looks good to the community. 😄