Skip to content
This repository was archived by the owner on Jan 23, 2025. It is now read-only.

Conversation

@irvile
Copy link
Contributor

@irvile irvile commented Mar 25, 2022

Feature

This feature was request in this issue #28

Screen.Recording.2022-03-25.at.14.43.06.mov

Closes #28

Could you review this PR? @leerob @thorwebdev

@vercel
Copy link

vercel bot commented Mar 25, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel-solutions-vtest314/nextjs-subscription-payments/Xs8hGL2mRPBJ9Ap8eYt2RnqSPeCY
✅ Preview: https://nextjs-subscription-paymen-git-d87a4e-vercel-solutions-vtest314.vercel.app

@tdeitz
Copy link

tdeitz commented Nov 10, 2022

Thanks @irvile, would also love it if this change could be merged :)

Thanks again to the team responsible for this great starter!

@tdeitz
Copy link

tdeitz commented Nov 10, 2022

Actually @irvile, I do get a typescript error with this function:

const updateUserFullname = async (userId: string, newFullName: string) => {
    const { data, error } = await supabase
      .from<UserDetails>('users')
      .update({ full_name: newFullName })
      .match({ id: userId });

    if (data) {
      setUserDetails(data[0]);
    }

    return error;
  };

No overload expects 1 type arguments, but overloads do exist that expect either 0 or 2 type arguments.

Any ideas how to resolve this?

@irvile
Copy link
Contributor Author

irvile commented Nov 10, 2022

Hi @tdeitz , I dont get this error. This error show when call a function and pass it a parameter that doesn't match any of its specified overloads.

I will update my branch to solve these conflicts, they updated supabase dependencies.
Hope help you.

@tdeitz
Copy link

tdeitz commented Nov 10, 2022

@irvile thanks very much for the reply. I'm a Typescript amateur (at best), so my debugging ability is pretty limited for now. Appreciate the branch update, thanks again :)

@vercel
Copy link

vercel bot commented Nov 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nextjs-subscription-payments ✅ Ready (Inspect) Visit Preview Nov 10, 2022 at 2:39PM (UTC)

@irvile
Copy link
Contributor Author

irvile commented Nov 10, 2022

@tdeitz done! This error that you commented show up because the new version of supabase v2, don't accept Type as the last version( supabase.from<UserDetails>)

Welcome! Its a pleasure help. Let me know if you have any other issue. I tested right now and supabase and stripe works fine.

@tdeitz
Copy link

tdeitz commented Nov 11, 2022

@irvile thanks so much, really appreciate your efforts, can't wait to have a look! :)

@adrientiburce
Copy link

Hello,
is there any blocker for this PR to be merged ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Account Details Update Buttons

3 participants