Repository navigation
[lts-active] test: remove unsupported deployment ID builder cases - #98821
Merged
Merged
Conversation
### What? Removes the legacy Vercel builder rows from the immutable-assets deployment ID determinism test. Direct `.next` output and Vercel adapter output remain covered, including both the standard and Cache Components fixtures. ### Why? Current `vercel@latest` rejects `_next/static/immutable` output when the Next.js adapter is disabled. Disabling immutable assets is not a valid replacement for these cases: it adds the deployment ID to asset URLs, which intentionally changes content-hashed CSS filenames between builds. This intentionally removes the two legacy-builder deploy-mode cases rather than skipping or weakening their determinism assertions. The current legacy builder no longer supports the immutable-output contract the test verifies. ### How? The Build Output API matrix now exercises only adapter mode, and `NEXT_ENABLE_ADAPTER=1` is applied unconditionally. The shared two-build comparison and all assertions for the retained direct and adapter cases are unchanged. Builder-only mode branching and timeout handling are removed. ### Verification - `pnpm prettier --with-node-modules --ignore-path .prettierignore --check test/production/deterministic-build/deployment-id.test.ts` - `pnpm eslint --config eslint.config.mjs test/production/deterministic-build/deployment-id.test.ts` - `pnpm test-start-turbo test/production/deterministic-build/deployment-id.test.ts` (3 tests passed) <!-- NEXT_JS_LLM --> <!-- fleet 00754f3b-4965-4d6d-bc4c-4dbab7b188e4 --> Co-authored-by: vercel-fleet-prod[bot] <318278635+vercel-fleet-prod[bot]@users.noreply.github.com> Co-authored-by: Tobias Koppers <1365881+sokra@users.noreply.github.com>
Contributor
Tests PassedCommit: 38f0466 |
eps1lon
marked this pull request as ready for review
September 17, 2026 14:38
unstubbable
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #98668
...to fix deployment tests.
Test does not exist on lts-maintenance so this is the only necessary backport.