[with-emotion-10,11] Update emotion examples to v10 & v11 #9646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: 313d5bf |
Andarist
reviewed
Dec 7, 2019
| @@ -0,0 +1,2 @@ | |||
| import createCache from '@emotion/cache' | |||
| export const emotionCache = createCache() | |||
There was a problem hiding this comment.
this works, but if you dont need to configure cache you might want to just reuse the one in emotion package
import { cache } from 'emotion'
``
Then you could also just use `emotion-server` instead of `create-emotion-server` (for simplicity). 
azizhk
changed the title
|
@azizhk is this still work in progress? |
|
Sorry for the clutter @timneutkens |
|
Yeah - sorry for not delivering v11 yet. With holidays and all in December, it was hard to put much time into the project. There is not that much left to do, so hopefully, we should ship soon-ish. Keep in mind that we do this in our free time, so even if we don't have much left to do it still can take few more weeks. |
|
@Andarist you don't need to apologise. Respect for all open source developers. 🤗 |
|
@Andarist I've made the requested changes: |
azizhk
changed the title
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: 7e12529 |
Andarist
reviewed
Jan 6, 2020
| @@ -12,11 +12,12 @@ | |||
| "author": "Thomas Greco", | |||
| "license": "ISC", | |||
| "dependencies": { | |||
| "emotion": "^8.0.11", | |||
| "emotion-server": "^8.0.11", | |||
| "@emotion/core": "10.0.27", | |||
There was a problem hiding this comment.
this package.json probably shouldn't have the same "name" as the one targeting v11
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: 91989bb |
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles
Commit: 7456eab |
Timer
changed the title
This was referenced Feb 18, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following https://emotion.sh/docs/migrating-to-emotion-10
I know that Emotion does support out of the box SSR now but it has some issues:
So that is why this is needed.