Add Failing tests for empty shells with dynamic params#95872
Open
gnoff wants to merge 2 commits into
Open
Conversation
Contributor
Stats from current PRWarning No stats were collected for Webpack because its stats job did not complete (it failed, was cancelled, or timed out). The results below only cover the bundlers that finished. ✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URLCommit: 13bd38d |
Contributor
Failing test suitesCommit: 13bd38d | About building and testing Next.js
Expand output● cache-components-prerender-matrix › partial-static-param/with-root-param/non-empty-shell › does not share the entry at lang=en category=fresh id=fresh across category values (category included in the cache key) ● cache-components-prerender-matrix › fully-static-param/without-root-param/non-empty-shell › serves the whole document from the cache at lang=fresh category=fresh id=fresh ● cache-components-prerender-matrix › fully-static-param/without-root-param/non-empty-shell › serves the whole document from the cache at lang=en category=fresh id=fresh ● cache-components-prerender-matrix › fully-static-param/without-root-param/non-empty-shell › serves the whole document from the cache at lang=en category=shoes id=fresh ● cache-components-prerender-matrix › fully-static-param/with-root-param/non-empty-shell › serves the whole document from the cache at lang=en category=fresh id=fresh ● cache-components-prerender-matrix › fully-static-param/with-root-param/non-empty-shell › serves the whole document from the cache at lang=en category=shoes id=fresh |
gnoff
force-pushed
the
jstory/fix-allow-query-empty-shell
branch
2 times, most recently
from
July 17, 2026 20:57
55eb582 to
1328eb6
Compare
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
gnoff
force-pushed
the
jstory/fix-allow-query-empty-shell
branch
2 times, most recently
from
July 17, 2026 21:12
4c47681 to
ab8fb05
Compare
params that are always dynamic (no generateStaticParam) in Cache Components should never be prerendered. This commit adds tests that pass in self hosted but fail in Vercel adapter and vercel's legacy mode.
gnoff
force-pushed
the
jstory/fix-allow-query-empty-shell
branch
from
July 17, 2026 22:23
ab8fb05 to
13bd38d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
params that are always dynamic (no generateStaticParam) in Cache Components should never be prerendered. This commit adds tests that pass in self hosted but fail in Vercel adapter and vercel's legacy mode.