Skip to content

Fix support for custom-media-queries in LightningCSS#95689

Merged
sampoder merged 1 commit into
canaryfrom
sp/lightningcss/custom-media
Jul 10, 2026
Merged

Fix support for custom-media-queries in LightningCSS#95689
sampoder merged 1 commit into
canaryfrom
sp/lightningcss/custom-media

Conversation

@sampoder

@sampoder sampoder commented Jul 10, 2026

Copy link
Copy Markdown
Member

Closes #95677. Added an e2e test that roughly matches the original issue and tests that it works.

@github-actions

github-actions Bot commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Stats from current PR

🔴 1 regression

Metric Canary PR Change Trend
Webpack Cold (First Request) 3.337s 3.446s 🔴 +109ms (+3%) ▁▃▂▆▃
📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 812ms 760ms ✓ ▂█▂▁▁
Cold (Ready in log) 769ms 761ms ✓ ▂█▁▁▁
Cold (First Request) 1.278s 1.284s ✓ ▃█▁▁▁
Warm (Listen) 760ms 763ms ✓ ▂█▂▁▁
Warm (Ready in log) 761ms 769ms ✓ ▂█▁▁▁
Warm (First Request) 1.284s 1.309s ✓ ▂█▁▁▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 811ms 814ms ✓ ▁▄▁▅▅
Cold (Ready in log) 775ms 790ms ✓ ▂▃▃▄▃
Cold (First Request) 3.337s 3.446s 🔴 +109ms (+3%) ▁▃▂▆▃
Warm (Listen) 813ms 813ms ✓ ▁█▁██
Warm (Ready in log) 780ms 785ms ✓ ▂▃▂▅▃
Warm (First Request) 3.350s 3.406s ✓ ▁▂▃▆▂

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 5.001s 4.865s ✓ ▄█▁▁▁
Cached Build 4.945s 4.922s ✓ ▄█▁▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 24.402s 24.353s ✓ ▅▃▄▅▁
Cached Build 24.602s 24.613s ✓ ▃▃▃▅▁
node_modules Size 514 MB 514 MB ✓ ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles
Canary PR Change
03gmyxr7dukvs.js gzip 10.3 kB N/A -
040t1q17lo593.js gzip 8.77 kB N/A -
09e3-09qkiwi_.js gzip 154 B N/A -
0bb0vtp8dwsez.js gzip 450 B N/A -
0cz1d0mv5g_q7.js gzip 39.4 kB 39.4 kB ✓
0dbc-rx1a2ia7.js gzip 157 B N/A -
0l0sr6gau5xjn.js gzip 3.53 kB N/A -
0nxqz3q165m2l.js gzip 220 B N/A -
0qr-1tnb7_hg5.js gzip 5.72 kB N/A -
0sltm7_bk3a1z.js gzip 162 B N/A -
0t99y0b13gop7.js gzip 156 B N/A -
0uilzvklme4ea.js gzip 8.76 kB N/A -
0xfw2y3-7r_ls.js gzip 71.1 kB N/A -
0z0y83mfx-l-h.js gzip 10 kB N/A -
15ok8ydf274z0.js gzip 10.6 kB N/A -
16cqqcigykfea.js gzip 13.6 kB N/A -
17h18zxt1915l.js gzip 1.46 kB N/A -
1d0jkvp9vscx7.js gzip 169 B N/A -
1elt1qium-r2m.css gzip 115 B 115 B ✓
1fq1h7dxad4cv.js gzip 9.44 kB N/A -
1fym-adbk_69_.js gzip 13.1 kB N/A -
1g80-jfls9qyr.js gzip 13.2 kB N/A -
1gav7nfh4y8ln.js gzip 8.76 kB N/A -
1mlpyr_6q1d4i.js gzip 159 B N/A -
1xrwtig-026j5.js gzip 153 B N/A -
22sajk3amu-ua.js gzip 45 kB N/A -
2i6koxfjo61y9.js gzip 155 B N/A -
2istwwmh1udo9.js gzip 65.5 kB N/A -
2ob2eotxku98d.js gzip 157 B N/A -
2rypqffktcxqh.js gzip 8.69 kB N/A -
2u2l1sy7k8y4k.js gzip 158 B N/A -
2uqsizxtehgqf.js gzip 8.79 kB N/A -
2vzktdqwbijqc.js gzip 8.74 kB N/A -
30z6tw9p09o6p.js gzip 154 B N/A -
3avu73u9nrnm1.js gzip 161 B N/A -
3c244akvx_-be.js gzip 8.74 kB N/A -
3dmlemitx3ef3.js gzip 2.29 kB N/A -
3l3k9bp7sg6xx.js gzip 158 B N/A -
3y193x4n8cq9d.js gzip 7.4 kB N/A -
4237vdj6eyslt.js gzip 8.7 kB N/A -
turbopack-01..ml6z.js gzip 3.85 kB N/A -
turbopack-05..wpzh.js gzip 3.85 kB N/A -
turbopack-0p..i6vq.js gzip 3.85 kB N/A -
turbopack-0s..3jys.js gzip 3.84 kB N/A -
turbopack-0t..dkdl.js gzip 3.83 kB N/A -
turbopack-1c..k7fn.js gzip 3.85 kB N/A -
turbopack-1n..vkr2.js gzip 3.85 kB N/A -
turbopack-1o..98i0.js gzip 3.84 kB N/A -
turbopack-1s..mpt3.js gzip 3.85 kB N/A -
turbopack-2-..w2pz.js gzip 3.85 kB N/A -
turbopack-27..3yam.js gzip 3.85 kB N/A -
turbopack-2c.._sng.js gzip 3.85 kB N/A -
turbopack-3e..239v.js gzip 3.86 kB N/A -
turbopack-3e..yzc-.js gzip 3.85 kB N/A -
00tc16j5-eos9.js gzip N/A 1.46 kB -
05m7resy3d9y7.js gzip N/A 151 B -
05tax4x1rfda4.js gzip N/A 7.4 kB -
0aj4x2hphgty5.js gzip N/A 154 B -
0gaw1gmpwuwkn.js gzip N/A 8.8 kB -
0huyy5urnlltn.js gzip N/A 71.1 kB -
0kxj3ykdj07z4.js gzip N/A 159 B -
0pojt-ky84hkd.js gzip N/A 154 B -
0tghdd6xl2yqt.js gzip N/A 156 B -
10urlqkrqqymx.js gzip N/A 65.5 kB -
12zyjjmq4oad1.js gzip N/A 5.72 kB -
1ap4-1agtnoy9.js gzip N/A 155 B -
1h5_xp52n46gh.js gzip N/A 159 B -
1k9cc4-gpa2cx.js gzip N/A 13.1 kB -
1n59uogejo81s.js gzip N/A 10.3 kB -
1npei3hlexdv3.js gzip N/A 9.99 kB -
1ssuiwj_rnpc5.js gzip N/A 8.77 kB -
1whujog9k04ct.js gzip N/A 156 B -
2-kmvvx8076lt.js gzip N/A 156 B -
2-phc9obd3nyd.js gzip N/A 8.77 kB -
22mrzncuyl9s7.js gzip N/A 153 B -
24utq57r3l1cw.js gzip N/A 8.7 kB -
2fhjq6ek3srmr.js gzip N/A 8.69 kB -
2g0t7upz_v-hf.js gzip N/A 10.6 kB -
2ia3slz01gf4a.js gzip N/A 153 B -
2ia9qqy99aie9.js gzip N/A 13.6 kB -
2oza28kdqvoay.js gzip N/A 8.74 kB -
2tr7uivjsoa8w.js gzip N/A 153 B -
2zh8-mmhujy8o.js gzip N/A 2.29 kB -
30h_m0irj-q6p.js gzip N/A 221 B -
37ejbfx1u9lpo.js gzip N/A 8.75 kB -
38c63ct4i1cy7.js gzip N/A 449 B -
3hd1us4ordyc9.js gzip N/A 13.2 kB -
3jimpal3lvz5e.js gzip N/A 9.44 kB -
3miwoh_m6v2ln.js gzip N/A 166 B -
3ns42zoevxrsp.js gzip N/A 45 kB -
3su6a4l8jbfth.js gzip N/A 3.53 kB -
3wb4pe4z4-aim.js gzip N/A 8.77 kB -
turbopack-00..q--7.js gzip N/A 3.84 kB -
turbopack-0b..4h50.js gzip N/A 3.84 kB -
turbopack-11..094w.js gzip N/A 3.84 kB -
turbopack-1d.._6cf.js gzip N/A 3.84 kB -
turbopack-1h..jax5.js gzip N/A 3.84 kB -
turbopack-1l..45d2.js gzip N/A 3.84 kB -
turbopack-1m..f893.js gzip N/A 3.84 kB -
turbopack-1u..w4lz.js gzip N/A 3.84 kB -
turbopack-23.._g7o.js gzip N/A 3.84 kB -
turbopack-27..sfi5.js gzip N/A 3.82 kB -
turbopack-2i..so4d.js gzip N/A 3.85 kB -
turbopack-2t..-gzx.js gzip N/A 3.86 kB -
turbopack-2y..s72r.js gzip N/A 3.84 kB -
turbopack-3k..2y2h.js gzip N/A 3.84 kB -
Total 448 kB 448 kB ✅ -15 B

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 733 B 719 B 🟢 14 B (-2%)
Total 733 B 719 B ✅ -14 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 433 B 434 B ✓
Total 433 B 434 B ⚠️ +1 B

📦 Webpack

Client

Main Bundles
Canary PR Change
2486.HASH.js gzip 169 B N/A -
3146-HASH.js gzip 64 kB N/A -
39fcf99b-HASH.js gzip 62.9 kB N/A -
8443-HASH.js gzip 4.68 kB N/A -
9431-HASH.js gzip 5.62 kB N/A -
framework-HASH.js gzip 59.8 kB 59.8 kB ✓
main-app-HASH.js gzip 255 B 253 B ✓
main-HASH.js gzip 39.6 kB 40.1 kB 🔴 +455 B (+1%)
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
6105-HASH.js gzip N/A 5.63 kB -
764.HASH.js gzip N/A 169 B -
8898-HASH.js gzip N/A 63.4 kB -
9597-HASH.js gzip N/A 4.65 kB -
e1ccab69-HASH.js gzip N/A 62.9 kB -
Total 239 kB 238 kB ✅ -142 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 183 B 182 B ✓
css-HASH.js gzip 335 B 335 B ✓
dynamic-HASH.js gzip 1.8 kB 1.8 kB ✓
edge-ssr-HASH.js gzip 255 B 254 B ✓
head-HASH.js gzip 351 B 349 B ✓
hooks-HASH.js gzip 384 B 384 B ✓
image-HASH.js gzip 580 B 580 B ✓
index-HASH.js gzip 259 B 259 B ✓
link-HASH.js gzip 2.49 kB 2.49 kB ✓
routerDirect..HASH.js gzip 319 B 319 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 315 B 313 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.96 kB 7.95 kB ✅ -7 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 127 kB 127 kB ✓
page.js gzip 278 kB 280 kB ✓
Total 406 kB 407 kB ⚠️ +1.79 kB
Middleware
Canary PR Change
middleware-b..fest.js gzip 617 B 616 B ✓
middleware-r..fest.js gzip 156 B 155 B ✓
middleware.js gzip 44.8 kB 44.9 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 46.4 kB 46.5 kB ⚠️ +45 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 719 B 720 B ✓
Total 719 B 720 B ⚠️ +1 B
Build Cache
Canary PR Change
0.pack gzip 4.76 MB 4.75 MB 🟢 8.72 kB (0%)
index.pack gzip 118 kB 117 kB ✓
index.pack.old gzip 117 kB 118 kB ✓
Total 5 MB 4.99 MB ✅ -8.85 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 361 kB 361 kB ✓
app-page-exp..prod.js gzip 199 kB 199 kB ✓
app-page-tur...dev.js gzip 361 kB 361 kB ✓
app-page-tur..prod.js gzip 199 kB 199 kB ✓
app-page-tur...dev.js gzip 357 kB 357 kB ✓
app-page-tur..prod.js gzip 197 kB 197 kB ✓
app-page.run...dev.js gzip 358 kB 358 kB ✓
app-page.run..prod.js gzip 197 kB 197 kB ✓
app-route-ex...dev.js gzip 79.1 kB 79.1 kB ✓
app-route-ex..prod.js gzip 53.6 kB 53.6 kB ✓
app-route-tu...dev.js gzip 79.1 kB 79.1 kB ✓
app-route-tu..prod.js gzip 53.6 kB 53.6 kB ✓
app-route-tu...dev.js gzip 78.7 kB 78.7 kB ✓
app-route-tu..prod.js gzip 53.4 kB 53.4 kB ✓
app-route.ru...dev.js gzip 78.7 kB 78.7 kB ✓
app-route.ru..prod.js gzip 53.3 kB 53.3 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 45.2 kB 45.2 kB ✓
pages-api-tu..prod.js gzip 34 kB 34 kB ✓
pages-api.ru...dev.js gzip 45.2 kB 45.2 kB ✓
pages-api.ru..prod.js gzip 33.9 kB 33.9 kB ✓
pages-turbo....dev.js gzip 54.7 kB 54.7 kB ✓
pages-turbo...prod.js gzip 39.6 kB 39.6 kB ✓
pages.runtim...dev.js gzip 54.7 kB 54.7 kB ✓
pages.runtim..prod.js gzip 39.6 kB 39.6 kB ✓
server.runti..prod.js gzip 65.2 kB 65.2 kB ✓
use-cache-pr...dev.js gzip 71.4 kB 71.4 kB ✓
use-cache-pr...dev.js gzip 71.4 kB 71.4 kB ✓
use-cache-pr...dev.js gzip 69.7 kB 69.7 kB ✓
use-cache-pr...dev.js gzip 69.7 kB 69.7 kB ✓
Total 3.46 MB 3.46 MB ✅ -4 B
📝 Changed Files (2 files)

Files with changes:

  • pages-api-tu..time.prod.js
  • pages-turbo...time.prod.js
View diffs
pages-api-tu..time.prod.js

Diff too large to display

pages-turbo...time.prod.js

Diff too large to display

📎 Tarball URL 
https://vercel-packages.vercel.app/next/commits/b9d34df9dbaf586cd50dd82508405c159ba37f8e/next

Commit: b9d34df

@github-actions

github-actions Bot commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Tests Passed

Commit: b9d34df

@sampoder sampoder enabled auto-merge (squash) July 10, 2026 18:15
@sampoder sampoder merged commit 4b1c74a into canary Jul 10, 2026
129 checks passed
@sampoder sampoder deleted the sp/lightningcss/custom-media branch July 10, 2026 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wbinnssmith wbinnssmith wbinnssmith approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Turbopack: @custom-media is not getting compiled by LightningCSS

2 participants

@sampoder @wbinnssmith