test: allow-runtime breaks Link's Server component child detection#95596
Merged
Conversation
Contributor
Tests PassedCommit: 04e0a32 |
Contributor
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URLCommit: 04e0a32 |
lubieowoce
changed the title
lubieowoce
force-pushed
the
lubieowoce/legacy-behavior-runtime
branch
2 times, most recently
from
23c4ce3 to
844ee48
Compare
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
lubieowoce
force-pushed
the
lubieowoce/legacy-behavior-runtime
branch
from
844ee48 to
65f4224
Compare
lubieowoce
changed the title
allow-runtime moves the segment to an earlier stage (EarlyStatic vs Static), which seems to somehow affect the timing of the Link child's debugInfo -- the debugInfo is not available when the Flight Client decodes the Link's child, so the child becomes blocked and turned into a lazy, which in turn triggers the validation Link has against passing server components as children.
lubieowoce
force-pushed
the
lubieowoce/legacy-behavior-runtime
branch
from
65f4224 to
04e0a32
Compare
gnoff
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See NAR-876. We discovered this problem in #95384, when removing the Early/Late stage split, but it turns out that this was a preexisting race that occurs for runtime-prefetchable segments the problem existed before for runtime (which currently render in EarlyStatic, a task earlier than non-runtime-prefetchable segments)
adds failing tests for
passHrefwith allow-runtime (i.e. when the segment runs early), and passing tests for it in the dynamic stage (when the passHref is gated behind dynamic, which seems to delay it long enough for the debug channel to initialize)