Skip to content

[turbopack] Compile service workers registered from pages router pages#95583

Merged
sampoder merged 1 commit into
canaryfrom
sp/turbopack/sw-pages
Jul 9, 2026
Merged

[turbopack] Compile service workers registered from pages router pages#95583
sampoder merged 1 commit into
canaryfrom
sp/turbopack/sw-pages

Conversation

@sampoder

@sampoder sampoder commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Thanks @mischnic for catching this! I've added a test to ensure that service workers work in pages router.

@github-actions

github-actions Bot commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Tests Passed

Commit: dd3f23f

@github-actions

github-actions Bot commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 763ms 812ms ✓ ▁████
Cold (Ready in log) 766ms 779ms ✓ ▃▅▆▄█
Cold (First Request) 1.313s 1.290s ✓ ▁▄▄▃█
Warm (Listen) 812ms 813ms ✓ █████
Warm (Ready in log) 773ms 781ms ✓ ▄▆▆▆█
Warm (First Request) 1.283s 1.323s ✓ ▃▄▂▃█
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 814ms 813ms ✓ ▄▁▁█▄
Cold (Ready in log) 782ms 809ms ✓ ▄▁▁█▅
Cold (First Request) 3.370s 3.392s ✓ ▄▂▁▇▆
Warm (Listen) 813ms 813ms ✓ █▁▁██
Warm (Ready in log) 786ms 796ms ✓ ▄▂▂█▅
Warm (First Request) 3.454s 3.470s ✓ ▃▂▁▇▆

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.959s 5.034s ✓ ▁▄▂▁█
Cached Build 5.059s 5.090s ✓ ▁▄▆▃▇
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 25.682s 25.698s ✓ ▃▁▁▆█
Cached Build 25.835s 25.814s ✓ ▃▁▁█▆
node_modules Size 515 MB 515 MB ✓ ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles
Canary PR Change
01mcsxsyr_he2.js gzip 71.1 kB N/A -
03gmyxr7dukvs.js gzip 10.3 kB N/A -
040t1q17lo593.js gzip 8.77 kB N/A -
0acse__myyi12.js gzip 169 B N/A -
0bb0vtp8dwsez.js gzip 450 B N/A -
0cz1d0mv5g_q7.js gzip 39.4 kB 39.4 kB ✓
0l0sr6gau5xjn.js gzip 3.53 kB N/A -
0nxqz3q165m2l.js gzip 220 B N/A -
0qr-1tnb7_hg5.js gzip 5.72 kB N/A -
0uilzvklme4ea.js gzip 8.76 kB N/A -
0z0y83mfx-l-h.js gzip 10 kB N/A -
15ok8ydf274z0.js gzip 10.6 kB N/A -
16cqqcigykfea.js gzip 13.6 kB N/A -
16p6k4rvlk8hs.js gzip 156 B N/A -
17h18zxt1915l.js gzip 1.46 kB N/A -
1elt1qium-r2m.css gzip 115 B 115 B ✓
1fq1h7dxad4cv.js gzip 9.44 kB N/A -
1fym-adbk_69_.js gzip 13.1 kB N/A -
1g80-jfls9qyr.js gzip 13.2 kB N/A -
1gav7nfh4y8ln.js gzip 8.76 kB N/A -
1pirlzcqpboke.js gzip 157 B N/A -
22sajk3amu-ua.js gzip 45 kB N/A -
2b47thog_o22q.js gzip 158 B N/A -
2nh_8jlh884jn.js gzip 161 B N/A -
2oyxoidxog322.js gzip 65.5 kB N/A -
2rypqffktcxqh.js gzip 8.69 kB N/A -
2uqsizxtehgqf.js gzip 8.79 kB N/A -
2vzktdqwbijqc.js gzip 8.74 kB N/A -
3afhrvsbhvr34.js gzip 156 B N/A -
3ak6zl4zjnt8w.js gzip 155 B N/A -
3c244akvx_-be.js gzip 8.74 kB N/A -
3dmlemitx3ef3.js gzip 2.29 kB N/A -
3ffc-vg2dfz3_.js gzip 155 B N/A -
3od-h0_3-qwrn.js gzip 161 B N/A -
3y193x4n8cq9d.js gzip 7.4 kB N/A -
3y3blyb4ymhm2.js gzip 153 B N/A -
3ykopt545p33e.js gzip 157 B N/A -
40ihydltprauy.js gzip 156 B N/A -
4237vdj6eyslt.js gzip 8.7 kB N/A -
43bfotaq-14ip.js gzip 154 B N/A -
turbopack-07..s8o7.js gzip 3.85 kB N/A -
turbopack-08..e1gp.js gzip 3.85 kB N/A -
turbopack-08..c-or.js gzip 3.84 kB N/A -
turbopack-0o..gxwn.js gzip 3.85 kB N/A -
turbopack-0q..-9tl.js gzip 3.83 kB N/A -
turbopack-0y..emj9.js gzip 3.84 kB N/A -
turbopack-1_..v-s0.js gzip 3.85 kB N/A -
turbopack-1d..5zex.js gzip 3.84 kB N/A -
turbopack-1o..3j31.js gzip 3.85 kB N/A -
turbopack-1x..-mzg.js gzip 3.85 kB N/A -
turbopack-2r..sgjm.js gzip 3.86 kB N/A -
turbopack-3b..fo18.js gzip 3.85 kB N/A -
turbopack-3k..nny0.js gzip 3.85 kB N/A -
turbopack-40..u_28.js gzip 3.85 kB N/A -
00tc16j5-eos9.js gzip N/A 1.46 kB -
05tax4x1rfda4.js gzip N/A 7.4 kB -
0ej25wuqhwna-.js gzip N/A 155 B -
0gaw1gmpwuwkn.js gzip N/A 8.8 kB -
0l71aswcqfx-_.js gzip N/A 152 B -
12zyjjmq4oad1.js gzip N/A 5.72 kB -
19oscshzjelcp.js gzip N/A 155 B -
1e60oe94c-qdx.js gzip N/A 167 B -
1k9cc4-gpa2cx.js gzip N/A 13.1 kB -
1n59uogejo81s.js gzip N/A 10.3 kB -
1npei3hlexdv3.js gzip N/A 9.99 kB -
1ssuiwj_rnpc5.js gzip N/A 8.77 kB -
1wli4rczh90gc.js gzip N/A 154 B -
2-phc9obd3nyd.js gzip N/A 8.77 kB -
24utq57r3l1cw.js gzip N/A 8.7 kB -
2atpv2oo9yu1i.js gzip N/A 155 B -
2fhjq6ek3srmr.js gzip N/A 8.69 kB -
2fvnps--3eqav.js gzip N/A 154 B -
2g0t7upz_v-hf.js gzip N/A 10.6 kB -
2gipd1kxr2gbo.js gzip N/A 155 B -
2h0sgjzpt5j0a.js gzip N/A 153 B -
2ia9qqy99aie9.js gzip N/A 13.6 kB -
2n337-mum3n5w.js gzip N/A 156 B -
2oza28kdqvoay.js gzip N/A 8.74 kB -
2ybks07m-a5ag.js gzip N/A 155 B -
2zh8-mmhujy8o.js gzip N/A 2.29 kB -
30h_m0irj-q6p.js gzip N/A 221 B -
37ejbfx1u9lpo.js gzip N/A 8.75 kB -
38c63ct4i1cy7.js gzip N/A 449 B -
3hd1us4ordyc9.js gzip N/A 13.2 kB -
3jimpal3lvz5e.js gzip N/A 9.44 kB -
3ns42zoevxrsp.js gzip N/A 45 kB -
3q1x790o0i9--.js gzip N/A 71.1 kB -
3qukz4yagu4v3.js gzip N/A 65.5 kB -
3su6a4l8jbfth.js gzip N/A 3.53 kB -
3wb4pe4z4-aim.js gzip N/A 8.77 kB -
3xtlj242vjngb.js gzip N/A 160 B -
3yqtt-b6_v5qn.js gzip N/A 160 B -
turbopack-03..c_u8.js gzip N/A 3.85 kB -
turbopack-05..li1y.js gzip N/A 3.85 kB -
turbopack-0o..-hpx.js gzip N/A 3.85 kB -
turbopack-12..z9p8.js gzip N/A 3.85 kB -
turbopack-1f..g5yn.js gzip N/A 3.85 kB -
turbopack-1w..-lc2.js gzip N/A 3.83 kB -
turbopack-2k..0cv1.js gzip N/A 3.85 kB -
turbopack-2x..dq3x.js gzip N/A 3.85 kB -
turbopack-37..d_l6.js gzip N/A 3.84 kB -
turbopack-3b..1h16.js gzip N/A 3.85 kB -
turbopack-3h..erel.js gzip N/A 3.85 kB -
turbopack-3h..22fn.js gzip N/A 3.84 kB -
turbopack-3j..city.js gzip N/A 3.85 kB -
turbopack-3k..bmba.js gzip N/A 3.86 kB -
Total 448 kB 448 kB ⚠️ +25 B

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 731 B 721 B 🟢 10 B (-1%)
Total 731 B 721 B ✅ -10 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 432 B 433 B ✓
Total 432 B 433 B ⚠️ +1 B

📦 Webpack

Client

Main Bundles
Canary PR Change
2486.HASH.js gzip 169 B N/A -
3146-HASH.js gzip 64 kB N/A -
39fcf99b-HASH.js gzip 62.9 kB N/A -
8443-HASH.js gzip 4.68 kB N/A -
9431-HASH.js gzip 5.62 kB N/A -
framework-HASH.js gzip 59.8 kB 59.8 kB ✓
main-app-HASH.js gzip 255 B 253 B ✓
main-HASH.js gzip 39.6 kB 40.1 kB 🔴 +455 B (+1%)
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
6105-HASH.js gzip N/A 5.63 kB -
764.HASH.js gzip N/A 169 B -
8898-HASH.js gzip N/A 63.4 kB -
9597-HASH.js gzip N/A 4.65 kB -
e1ccab69-HASH.js gzip N/A 62.9 kB -
Total 239 kB 238 kB ✅ -141 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 183 B 182 B ✓
css-HASH.js gzip 335 B 335 B ✓
dynamic-HASH.js gzip 1.8 kB 1.8 kB ✓
edge-ssr-HASH.js gzip 255 B 254 B ✓
head-HASH.js gzip 351 B 349 B ✓
hooks-HASH.js gzip 384 B 384 B ✓
image-HASH.js gzip 580 B 580 B ✓
index-HASH.js gzip 259 B 259 B ✓
link-HASH.js gzip 2.49 kB 2.49 kB ✓
routerDirect..HASH.js gzip 319 B 319 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 315 B 313 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.96 kB 7.95 kB ✅ -7 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 127 kB 127 kB ✓
page.js gzip 279 kB 281 kB ✓
Total 406 kB 408 kB ⚠️ +1.73 kB
Middleware
Canary PR Change
middleware-b..fest.js gzip 616 B 614 B ✓
middleware-r..fest.js gzip 156 B 155 B ✓
middleware.js gzip 44.7 kB 44.9 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 46.3 kB 46.5 kB ⚠️ +255 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 719 B 720 B ✓
Total 719 B 720 B ⚠️ +1 B
Build Cache
Canary PR Change
0.pack gzip 4.78 MB 4.77 MB 🟢 8.98 kB (0%)
index.pack gzip 116 kB 118 kB 🔴 +1.6 kB (+1%)
index.pack.old gzip 118 kB 119 kB ✓
Total 5.01 MB 5 MB ✅ -6.51 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 362 kB 362 kB ✓
app-page-exp..prod.js gzip 200 kB 200 kB ✓
app-page-tur...dev.js gzip 361 kB 361 kB ✓
app-page-tur..prod.js gzip 200 kB 200 kB ✓
app-page-tur...dev.js gzip 358 kB 358 kB ✓
app-page-tur..prod.js gzip 198 kB 198 kB ✓
app-page.run...dev.js gzip 358 kB 358 kB ✓
app-page.run..prod.js gzip 198 kB 198 kB ✓
app-route-ex...dev.js gzip 79.1 kB 79.1 kB ✓
app-route-ex..prod.js gzip 53.6 kB 53.6 kB ✓
app-route-tu...dev.js gzip 79.1 kB 79.1 kB ✓
app-route-tu..prod.js gzip 53.7 kB 53.7 kB ✓
app-route-tu...dev.js gzip 78.7 kB 78.7 kB ✓
app-route-tu..prod.js gzip 53.4 kB 53.4 kB ✓
app-route.ru...dev.js gzip 78.7 kB 78.7 kB ✓
app-route.ru..prod.js gzip 53.4 kB 53.4 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 45.2 kB 45.2 kB ✓
pages-api-tu..prod.js gzip 34 kB 34 kB ✓
pages-api.ru...dev.js gzip 45.2 kB 45.2 kB ✓
pages-api.ru..prod.js gzip 33.9 kB 33.9 kB ✓
pages-turbo....dev.js gzip 54.7 kB 54.7 kB ✓
pages-turbo...prod.js gzip 39.6 kB 39.6 kB ✓
pages.runtim...dev.js gzip 54.7 kB 54.7 kB ✓
pages.runtim..prod.js gzip 39.6 kB 39.6 kB ✓
server.runti..prod.js gzip 65.1 kB 65.1 kB ✓
use-cache-pr...dev.js gzip 71.3 kB 71.3 kB ✓
use-cache-pr...dev.js gzip 71.4 kB 71.4 kB ✓
use-cache-pr...dev.js gzip 69.7 kB 69.7 kB ✓
use-cache-pr...dev.js gzip 69.7 kB 69.7 kB ✓
Total 3.46 MB 3.46 MB ✓
📎 Tarball URL 
https://vercel-packages.vercel.app/next/commits/dd3f23f991bd71964b27da425e59ec990a62ee3e/next

Commit: dd3f23f

@sampoder sampoder changed the title sp/turbopack/sw pages [turbopack] Compile service workers registered from Pages Router pages Jul 7, 2026
@sampoder sampoder changed the title [turbopack] Compile service workers registered from Pages Router pages [turbopack] Compile service workers registered from pages router pages Jul 7, 2026
@sampoder sampoder marked this pull request as ready for review July 7, 2026 18:28
@sampoder sampoder requested a review from mischnic July 7, 2026 18:34
@sampoder sampoder force-pushed the sp/turbopack/sw-pages branch from 9054f37 to 547a1fe Compare July 7, 2026 20:06
@sampoder sampoder force-pushed the sp/turbopack/sw-static branch from 9f06adf to df96966 Compare July 7, 2026 20:19
@sampoder sampoder force-pushed the sp/turbopack/sw-pages branch 2 times, most recently from 7c868a7 to 6b7ba47 Compare July 7, 2026 22:02
Base automatically changed from sp/turbopack/sw-static to canary July 9, 2026 22:17
@sampoder sampoder force-pushed the sp/turbopack/sw-pages branch from 6b7ba47 to dd3f23f Compare July 9, 2026 22:50
@sampoder sampoder merged commit c594b9f into canary Jul 9, 2026
129 checks passed
@sampoder sampoder deleted the sp/turbopack/sw-pages branch July 9, 2026 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mischnic mischnic mischnic approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sampoder @mischnic