request insights: derive request history and fetch data (2/5)#93975
Merged
timneutkens merged 5 commits intoJul 12, 2026
Merged
Conversation
Contributor
Tests PassedCommit: 6e9860e |
feedthejim
force-pushed
the
request-insights/request-history
branch
from
aa67146 to
d704eca
Compare
timneutkens
force-pushed
the
request-insights/local-span-recorder
branch
from
09e3816 to
c8779dc
Compare
timneutkens
force-pushed
the
request-insights/request-history
branch
from
d704eca to
c869f76
Compare
Contributor
Stats from current PR🔴 1 regression, 1 improvement
📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📝 Changed Files (20 files)Files with changes:
View diffsapp-page-exp..ntime.dev.jsfailed to diffapp-page-exp..time.prod.jsfailed to diffapp-page-tur..ntime.dev.jsfailed to diffapp-page-tur..time.prod.jsfailed to diffapp-page-tur..ntime.dev.jsfailed to diffapp-page-tur..time.prod.jsfailed to diffapp-page.runtime.dev.jsfailed to diffapp-page.runtime.prod.jsfailed to diffapp-route-ex..ntime.dev.jsDiff too large to display app-route-ex..time.prod.jsDiff too large to display app-route-tu..ntime.dev.jsDiff too large to display app-route-tu..time.prod.jsDiff too large to display app-route-tu..ntime.dev.jsDiff too large to display app-route-tu..time.prod.jsDiff too large to display app-route.runtime.dev.jsDiff too large to display app-route.ru..time.prod.jsDiff too large to display pages-api-tu..ntime.dev.jsDiff too large to display pages-api.runtime.dev.jsDiff too large to display pages-turbo...ntime.dev.jsDiff too large to display pages.runtime.dev.jsDiff too large to display 📎 Tarball URLCommit: 6e9860e |
timneutkens
force-pushed
the
request-insights/request-history
branch
from
c869f76 to
92c79b6
Compare
timneutkens
force-pushed
the
request-insights/local-span-recorder
branch
from
c8779dc to
4cc9c25
Compare
timneutkens
force-pushed
the
request-insights/request-history
branch
from
92c79b6 to
b0b9396
Compare
timneutkens
force-pushed
the
request-insights/local-span-recorder
branch
from
3f01826 to
129f119
Compare
timneutkens
force-pushed
the
request-insights/request-history
branch
from
29d07a5 to
56ce019
Compare
mischnic
reviewed
Jul 8, 2026
Comment on lines
+38
to
+39
| const SENSITIVE_PARAM_NAME_RE = | ||
| /(?:^|[_-])(?:access[_-]?token|api[_-]?key|auth|authorization|code|cookie|credential|id[_-]?token|jwt|key|password|secret|session|signature|sig|token)(?:$|[_-])/i |
Member
There was a problem hiding this comment.
This looks overly specific? it would block access-token but not accesstoken?
I'd just do "contains any of these"?
Contributor
There was a problem hiding this comment.
Let's keep it as-is and verify if it's even relevant first by dogfooding the tab. I suspect it's not needed to even have this filter.
mischnic
reviewed
Jul 8, 2026
timneutkens
force-pushed
the
request-insights/local-span-recorder
branch
from
129f119 to
d63e2ea
Compare
timneutkens
force-pushed
the
request-insights/request-history
branch
2 times, most recently
from
2c81fa9 to
0a993aa
Compare
timneutkens
force-pushed
the
request-insights/local-span-recorder
branch
2 times, most recently
from
3a050d0 to
cb02682
Compare
timneutkens
force-pushed
the
request-insights/request-history
branch
from
0a993aa to
633b1bd
Compare
timneutkens
force-pushed
the
request-insights/local-span-recorder
branch
from
cb02682 to
b2ffb8f
Compare
timneutkens
force-pushed
the
request-insights/request-history
branch
from
633b1bd to
56c3d97
Compare
timneutkens
approved these changes
Jul 11, 2026
Adds bounded request insight aggregation from local framework spans and fetch metrics, including fetch timing, method, URL, status, cache status, cache reason, fetch index, span trace identity, events, links, and dedupe between span-derived and metric-derived fetch entries. Verification: - pnpm jest packages/next/src/server/lib/trace/request-insights.test.ts packages/next/src/server/lib/patch-fetch.test.ts --runInBand - pnpm --filter=next types
timneutkens
force-pushed
the
request-insights/local-span-recorder
branch
from
b2ffb8f to
6421469
Compare
timneutkens
force-pushed
the
request-insights/request-history
branch
from
56c3d97 to
b5fb280
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Builds the bounded request history store on top of local spans and fetch metrics. Request Insights now keeps the last 100 requests, dedupes fetch records, and preserves raw span details for later verbose consumers.
Stack:
Review Focus
AppRender.fetchspans.Proof In This PR
pnpm jest packages/next/src/server/lib/trace/request-insights.test.ts packages/next/src/server/lib/patch-fetch.test.ts --runInBandpnpm --filter=next typesDeferred Coverage