[turbopack] Render code frames on the turbopack side by lukesandberg · Pull Request #90534 · vercel/next.js

lukesandberg · 2026-02-25T18:55:42Z

Not that error rendering performance is critical, but it is silly to pass frame information from turbopack to js just to have js pass the same information back to native code to draw a frame.

lukesandberg · 2026-02-25T18:56:00Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

nextjs-bot · 2026-02-25T19:08:29Z

Failing test suites

Commit: 1999aaa | About building and testing Next.js

pnpm test-dev test/e2e/app-dir/typed-routes-validator/typed-routes-validator.test.ts (job)

typed-routes-validator > should have passing tsc after the server generated types (DD)

Expand output

● typed-routes-validator › should have passing tsc after the server generated types

expect(received).toEqual(expected) // deep equality

- Expected  - 1
+ Received  + 2

  Object {
    "stderr": "",
-   "stdout": "",
+   "stdout": "app/layout.tsx(1,37): error TS2304: Cannot find name 'LayoutProps'.
+ app/page.tsx(1,37): error TS2304: Cannot find name 'PageProps'.",
  }

  63 |       })
  64 |
> 65 |       expect({ stdout, stderr }).toEqual({
     |                                  ^
  66 |         stdout: '',
  67 |         stderr: '',
  68 |       })

  at Object.toEqual (e2e/app-dir/typed-routes-validator/typed-routes-validator.test.ts:65:34)

pnpm test-start-turbo test/e2e/app-dir/cache-components-errors/cache-components-errors.test.ts (turbopack) (job)

Cache Components Errors > Build With --prerender-debug > Sync Dynamic Request > cookies > should error the build with a runtime error (DD)
Cache Components Errors > Build With --prerender-debug > Sync Dynamic Request > headers > should error the build with a runtime error (DD)
Cache Components Errors > Build Without --prerender-debug > Sync Dynamic Request > cookies > should error the build with a runtime error (DD)
Cache Components Errors > Build Without --prerender-debug > Sync Dynamic Request > headers > should error the build with a runtime error (DD)

Expand output

● Cache Components Errors › Build With --prerender-debug › Sync Dynamic Request › cookies › should error the build with a runtime error

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `Cache Components Errors Build With --prerender-debug Sync Dynamic Request cookies should error the build with a runtime error 1`

- Snapshot  - 1
+ Received  + 1

@@ -1,10 +1,10 @@
  "Error occurred prerendering page "/sync-cookies". Read more: https://nextjs.org/docs/messages/prerender-error
  TypeError: <module-function>().get is not a function

  at CookiesReadingComponent (../app/sync-cookies/page.tsx:18:36)
      16 | async function CookiesReadingComponent() {
  -   17 |   // Cast to any as we removed UnsafeUnwrapped types, but still need to test with the sync access
  +   17 |   // Cast to any as we removed UnsafeUnwrapped types, but still need to test with the sync...
    > 18 |   const token = (cookies() as any).get('token')
         |                                    ^
      19 |
      20 |   return (
      21 |     <div> {
  at Object.toMatchInlineSnapshot (e2e/app-dir/cache-components-errors/cache-components-errors.test.ts:1195:32)

● Cache Components Errors › Build With --prerender-debug › Sync Dynamic Request › headers › should error the build with a runtime error

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `Cache Components Errors Build With --prerender-debug Sync Dynamic Request headers should error the build with a runtime error 1`

- Snapshot  - 1
+ Received  + 1

@@ -1,10 +1,10 @@
  "Error occurred prerendering page "/sync-headers". Read more: https://nextjs.org/docs/messages/prerender-error
  TypeError: <module-function>().get is not a function

  at HeadersReadingComponent (../app/sync-headers/page.tsx:18:40)
      16 | async function HeadersReadingComponent() {
  -   17 |   // Cast to any as we removed UnsafeUnwrapped types, but still need to test with the sync access
  +   17 |   // Cast to any as we removed UnsafeUnwrapped types, but still need to test with the sync...
    > 18 |   const userAgent = (headers() as any).get('user-agent')
         |                                        ^
      19 |   return (
      20 |     <div>
      21 |       this component reads the `user-agent` header synchronously: {userAgent} {
  at Object.toMatchInlineSnapshot (e2e/app-dir/cache-components-errors/cache-components-errors.test.ts:1529:32)

● Cache Components Errors › Build Without --prerender-debug › Sync Dynamic Request › cookies › should error the build with a runtime error

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `Cache Components Errors Build Without --prerender-debug Sync Dynamic Request cookies should error the build with a runtime error 1`

- Snapshot  - 1
+ Received  + 1

@@ -1,11 +1,11 @@
  "Error occurred prerendering page "/sync-cookies". Read more: https://nextjs.org/docs/messages/prerender-error
  TypeError: <module-function>().get is not a function

  at a (../app/sync-cookies/page.tsx:18:36)
        at b (<anonymous>)
      16 | async function CookiesReadingComponent() {
  -   17 |   // Cast to any as we removed UnsafeUnwrapped types, but still need to test with the sync access
  +   17 |   // Cast to any as we removed UnsafeUnwrapped types, but still need to test with the sync...
    > 18 |   const token = (cookies() as any).get('token')
         |                                    ^
      19 |
      20 |   return (
      21 |     <div> {
  at Object.toMatchInlineSnapshot (e2e/app-dir/cache-components-errors/cache-components-errors.test.ts:1233:32)

● Cache Components Errors › Build Without --prerender-debug › Sync Dynamic Request › headers › should error the build with a runtime error

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `Cache Components Errors Build Without --prerender-debug Sync Dynamic Request headers should error the build with a runtime error 1`

- Snapshot  - 1
+ Received  + 1

@@ -1,11 +1,11 @@
  "Error occurred prerendering page "/sync-headers". Read more: https://nextjs.org/docs/messages/prerender-error
  TypeError: <module-function>().get is not a function

  at a (../app/sync-headers/page.tsx:18:40)
        at b (<anonymous>)
      16 | async function HeadersReadingComponent() {
  -   17 |   // Cast to any as we removed UnsafeUnwrapped types, but still need to test with the sync access
  +   17 |   // Cast to any as we removed UnsafeUnwrapped types, but still need to test with the sync...
    > 18 |   const userAgent = (headers() as any).get('user-agent')
         |                                        ^
      19 |   return (
      20 |     <div>
      21 |       this component reads the `user-agent` header synchronously: {userAgent} {
  at Object.toMatchInlineSnapshot (e2e/app-dir/cache-components-errors/cache-components-errors.test.ts:1567:32)

codspeed-hq · 2026-02-25T19:16:51Z

Merging this PR will not alter performance

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks¹

_{Comparing native_frame_rendering (1999aaa) with code_frame_defence (562de08)}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

nextjs-bot · 2026-02-25T19:17:45Z

Stats from current PR

🔴 1 regression

Metric	Canary	PR	Change	Trend
Webpack Cold (First Request)	1.942s	2.274s	🔴 +332ms (+17%)	▁▂▆█▄

📊 All Metrics

📖 Metrics Glossary

Dev Server Metrics:

Listen = TCP port starts accepting connections
First Request = HTTP server returns successful response
Cold = Fresh build (no cache)
Warm = With cached build artifacts

Build Metrics:

Fresh = Clean build (no .next directory)
Cached = With existing .next directory

Change Thresholds:

Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
Size: Changes < 1KB AND < 1% are insignificant
All other changes are flagged to catch regressions

⚡ Dev Server

Metric	Canary	PR	Change	Trend
Cold (Listen)	455ms	455ms	✓	▁▁▁█▁
Cold (Ready in log)	438ms	435ms	✓	▂▁▁█▂
Cold (First Request)	1.274s	1.237s	✓	▄▁▁█▄
Warm (Listen)	457ms	456ms	✓	▁▁▁█▁
Warm (Ready in log)	441ms	444ms	✓	▁▁▁█▁
Warm (First Request)	344ms	346ms	✓	▁▁▁█▂

📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric	Canary	PR	Change	Trend
Cold (Listen)	456ms	455ms	✓	▅▅▁▅▁
Cold (Ready in log)	437ms	437ms	✓	▁▂█▆▅
Cold (First Request)	1.942s	2.274s	🔴 +332ms (+17%)	▁▂▆█▄
Warm (Listen)	456ms	456ms	✓	▃▃▃▃▁
Warm (Ready in log)	438ms	436ms	✓	▂▁▇▇▅
Warm (First Request)	1.966s	1.967s	✓	▂▁▄█▃

⚡ Production Builds

Metric	Canary	PR	Change	Trend
Fresh Build	3.985s	4.044s	✓	▁▁▁█▁
Cached Build	3.983s	3.938s	✓	▁▁▁█▁

📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric	Canary	PR	Change	Trend
Fresh Build	14.048s	14.076s	✓	▁▁▂█▂
Cached Build	14.171s	14.231s	✓	▁▂▃█▂
node_modules Size	475 MB	475 MB	✓	▁▁▁▁▁

📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **400 kB** → **400 kB** ✅ -13 B

80 files with content-based hashes (individual files not comparable between builds)

Server

Middleware

	Canary	PR	Change
middleware-b..fest.js gzip	764 B	764 B	✓
Total	764 B	764 B	✓

Build Details

Build Manifests

	Canary	PR	Change
_buildManifest.js gzip	451 B	452 B	✓
Total	451 B	452 B	⚠️ +1 B

📦 Webpack

Client

Main Bundles

	Canary	PR	Change
5528-HASH.js gzip	5.54 kB	N/A	-
6280-HASH.js gzip	58.3 kB	N/A	-
6335.HASH.js gzip	169 B	N/A	-
912-HASH.js gzip	4.59 kB	N/A	-
e8aec2e4-HASH.js gzip	62.6 kB	N/A	-
framework-HASH.js gzip	59.7 kB	59.7 kB	✓
main-app-HASH.js gzip	255 B	254 B	✓
main-HASH.js gzip	39.1 kB	39.1 kB	✓
webpack-HASH.js gzip	1.68 kB	1.68 kB	✓
262-HASH.js gzip	N/A	4.59 kB	-
2889.HASH.js gzip	N/A	169 B	-
5602-HASH.js gzip	N/A	5.55 kB	-
6948ada0-HASH.js gzip	N/A	62.6 kB	-
9544-HASH.js gzip	N/A	59 kB	-
Total	232 kB	233 kB	⚠️ +720 B

Polyfills

	Canary	PR	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Total	39.4 kB	39.4 kB	✓

Pages

	Canary	PR	Change
_app-HASH.js gzip	194 B	194 B	✓
_error-HASH.js gzip	183 B	180 B	🟢 3 B (-2%)
css-HASH.js gzip	331 B	330 B	✓
dynamic-HASH.js gzip	1.81 kB	1.81 kB	✓
edge-ssr-HASH.js gzip	256 B	256 B	✓
head-HASH.js gzip	351 B	352 B	✓
hooks-HASH.js gzip	384 B	383 B	✓
image-HASH.js gzip	580 B	581 B	✓
index-HASH.js gzip	260 B	260 B	✓
link-HASH.js gzip	2.5 kB	2.5 kB	✓
routerDirect..HASH.js gzip	320 B	319 B	✓
script-HASH.js gzip	386 B	386 B	✓
withRouter-HASH.js gzip	315 B	315 B	✓
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Total	7.97 kB	7.97 kB	✅ -2 B

Server

Edge SSR

	Canary	PR	Change
edge-ssr.js gzip	125 kB	125 kB	✓
page.js gzip	254 kB	254 kB	✓
Total	379 kB	379 kB	⚠️ +310 B

Middleware

	Canary	PR	Change
middleware-b..fest.js gzip	616 B	612 B	✓
middleware-r..fest.js gzip	156 B	155 B	✓
middleware.js gzip	43.8 kB	44 kB	✓
edge-runtime..pack.js gzip	842 B	842 B	✓
Total	45.4 kB	45.6 kB	⚠️ +231 B

Build Details

Build Manifests

	Canary	PR	Change
_buildManifest.js gzip	715 B	718 B	✓
Total	715 B	718 B	⚠️ +3 B

Build Cache

	Canary	PR	Change
0.pack gzip	4.01 MB	4.02 MB	🔴 +10.3 kB (+0%)
index.pack gzip	103 kB	103 kB	✓
index.pack.old gzip	104 kB	103 kB	✓
Total	4.22 MB	4.23 MB	⚠️ +9.95 kB

🔄 Shared (bundler-independent)

Runtimes

	Canary	PR	Change
app-page-exp...dev.js gzip	320 kB	320 kB	✓
app-page-exp..prod.js gzip	170 kB	170 kB	✓
app-page-tur...dev.js gzip	319 kB	319 kB	✓
app-page-tur..prod.js gzip	169 kB	169 kB	✓
app-page-tur...dev.js gzip	316 kB	316 kB	✓
app-page-tur..prod.js gzip	168 kB	168 kB	✓
app-page.run...dev.js gzip	316 kB	316 kB	✓
app-page.run..prod.js gzip	168 kB	168 kB	✓
app-route-ex...dev.js gzip	70.8 kB	70.8 kB	✓
app-route-ex..prod.js gzip	49.2 kB	49.2 kB	✓
app-route-tu...dev.js gzip	70.8 kB	70.8 kB	✓
app-route-tu..prod.js gzip	49.2 kB	49.2 kB	✓
app-route-tu...dev.js gzip	70.4 kB	70.4 kB	✓
app-route-tu..prod.js gzip	49 kB	49 kB	✓
app-route.ru...dev.js gzip	70.4 kB	70.4 kB	✓
app-route.ru..prod.js gzip	49 kB	49 kB	✓
dist_client_...dev.js gzip	324 B	324 B	✓
dist_client_...dev.js gzip	326 B	326 B	✓
dist_client_...dev.js gzip	318 B	318 B	✓
dist_client_...dev.js gzip	317 B	317 B	✓
pages-api-tu...dev.js gzip	43.2 kB	43.2 kB	✓
pages-api-tu..prod.js gzip	32.9 kB	32.9 kB	✓
pages-api.ru...dev.js gzip	43.2 kB	43.2 kB	✓
pages-api.ru..prod.js gzip	32.8 kB	32.8 kB	✓
pages-turbo....dev.js gzip	52.5 kB	52.5 kB	✓
pages-turbo...prod.js gzip	38.5 kB	38.5 kB	✓
pages.runtim...dev.js gzip	52.5 kB	52.5 kB	✓
pages.runtim..prod.js gzip	38.4 kB	38.4 kB	✓
server.runti..prod.js gzip	62 kB	61.9 kB	✓
Total	2.82 MB	2.82 MB	✅ -165 B

📝 Changed Files (1 file)

Files with changes:

server.runtime.prod.js

View diffs

server.runtime.prod.js

Diff too large to display

📎 Tarball URL

next@https://vercel-packages.vercel.app/next/prs/90534/next

nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. type: next labels Feb 25, 2026

lukesandberg mentioned this pull request Feb 25, 2026

Reimplement code frame rendering in native code #85592

Open

lukesandberg mentioned this pull request Feb 25, 2026

[turbopack] Make it possible to synchronously access native bindings #85787

Merged

lukesandberg changed the title ~~render code frames on the turbopack side~~ [turbopack] Render code frames on the turbopack side Feb 25, 2026

render code frames on the turbopack side

1999aaa

lukesandberg force-pushed the native_frame_rendering branch from 34f1ced to 1999aaa Compare February 26, 2026 00:19

lukesandberg force-pushed the code_frame_defence branch from f838eb7 to 562de08 Compare February 26, 2026 00:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[turbopack] Render code frames on the turbopack side#90534

[turbopack] Render code frames on the turbopack side#90534
lukesandberg wants to merge 1 commit intocode_frame_defencefrom
native_frame_rendering

lukesandberg commented Feb 25, 2026 •

edited

Loading

Uh oh!

lukesandberg commented Feb 25, 2026 •

edited

Loading

Uh oh!

nextjs-bot commented Feb 25, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Feb 25, 2026 •

edited

Loading

Uh oh!

nextjs-bot commented Feb 25, 2026 •

edited

Loading

⚡ Dev Server

📦 Dev Server (Webpack)

⚡ Production Builds

📦 Production Builds (Webpack)

Bundle Sizes

⚡ Turbopack

📦 Webpack

🔄 Shared (bundler-independent)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

lukesandberg commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lukesandberg commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nextjs-bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Failing test suites

Uh oh!

codspeed-hq bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

nextjs-bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Stats from current PR

🔴 1 regression

⚡ Dev Server

📦 Dev Server (Webpack)

⚡ Production Builds

📦 Production Builds (Webpack)

Bundle Sizes

⚡ Turbopack

📦 Webpack

🔄 Shared (bundler-independent)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lukesandberg commented Feb 25, 2026 •

edited

Loading

lukesandberg commented Feb 25, 2026 •

edited

Loading

nextjs-bot commented Feb 25, 2026 •

edited

Loading

codspeed-hq bot commented Feb 25, 2026 •

edited

Loading

nextjs-bot commented Feb 25, 2026 •

edited

Loading