url is considered as new if only a hash was changed from previous url#89051
Open
waqas2714 wants to merge 2 commits intovercel:canaryfrom
Open
url is considered as new if only a hash was changed from previous url#89051waqas2714 wants to merge 2 commits intovercel:canaryfrom
waqas2714 wants to merge 2 commits intovercel:canaryfrom
Conversation
Collaborator
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
timneutkens
requested changes
Jan 26, 2026
Member
timneutkens
left a comment
There was a problem hiding this comment.
PR looks incorrect. The test is checking App Router but the change is in the router for Pages Router, so won't work.
Author
|
Hi @timneutkens . I made the change in base router. Should it not affect both app and page router? Also, the issue was created for the app router hence the test case for app router. Sorry for any inconvenience, I am new to open source. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Contributors
Fixing a bug
fixes #88986test/e2e/app-dir/hash-navigationFor Maintainers
What?
Fixes hash navigation when using
next/linkso that clicking a link to the same hash (e.g.#section) triggers scrolling again.Previously, if the current URL already contained the same hash, Next.js treated it as a no-op and did not scroll.
Why?
This breaks expected browser behavior and real user flows:
Native anchors scroll again, but Next’s router skipped navigation due to the
onlyAHashChangelogic.This affects common patterns such as:
How?
The router logic was updated so that same-hash navigations are no longer ignored.
Instead of treating identical hash changes as a no-op, the router now explicitly allows the navigation, ensuring scroll behavior is applied again.
Closes NEXT-
Fixes #88986