Skip to content

Conversation

@bgw
Copy link
Member

@bgw bgw commented Nov 5, 2025

Turns out this is all dead code, so delete it!

It looks like this was added back in vercel/turborepo#3448, probably when Turbopack was trying to rewrite larger parts of Next.js than ended up happening.

@bgw bgw marked this pull request as ready for review November 5, 2025 00:12
@ijjk
Copy link
Member

ijjk commented Nov 5, 2025

Failing test suites

Commit: ed94bf5 | About building and testing Next.js

pnpm test-dev test/e2e/app-dir/fallback-shells/fallback-shells.test.ts

  • fallback-shells > with cached IO > with generateStaticParams > and the page wrapped in Suspense > and the params accessed in the cached page > resumes a postponed fallback shell (DD)
  • fallback-shells > without IO > should start and not postpone the response (DD)
Expand output

● fallback-shells › without IO › should start and not postpone the response

thrown: "Timed out waiting for the response of /without-io/world"

   8 |
   9 |   describe('without IO', () => {
> 10 |     it('should start and not postpone the response', async () => {
     |     ^
  11 |       const { browser, response } =
  12 |         await next.browserWithResponse('/without-io/world')
  13 |

  at it (e2e/app-dir/fallback-shells/fallback-shells.test.ts:10:5)
  at describe (e2e/app-dir/fallback-shells/fallback-shells.test.ts:9:3)
  at Object.describe (e2e/app-dir/fallback-shells/fallback-shells.test.ts:4:1)

● fallback-shells › with cached IO › with generateStaticParams › and the page wrapped in Suspense › and the params accessed in the cached page › resumes a postponed fallback shell

thrown: "Timed out waiting for the response of /with-cached-io/with-static-params/with-suspense/params-in-page/bar"

  29 |       describe('and the page wrapped in Suspense', () => {
  30 |         describe('and the params accessed in the cached page', () => {
> 31 |           it('resumes a postponed fallback shell', async () => {
     |           ^
  32 |             const { browser, response } = await next.browserWithResponse(
  33 |               '/with-cached-io/with-static-params/with-suspense/params-in-page/bar'
  34 |             )

  at it (e2e/app-dir/fallback-shells/fallback-shells.test.ts:31:11)
  at describe (e2e/app-dir/fallback-shells/fallback-shells.test.ts:30:9)
  at describe (e2e/app-dir/fallback-shells/fallback-shells.test.ts:29:7)
  at describe (e2e/app-dir/fallback-shells/fallback-shells.test.ts:28:5)
  at describe (e2e/app-dir/fallback-shells/fallback-shells.test.ts:27:3)
  at Object.describe (e2e/app-dir/fallback-shells/fallback-shells.test.ts:4:1)

@bgw bgw merged commit e989fcb into canary Nov 5, 2025
427 of 433 checks passed
Copy link
Member Author

bgw commented Nov 5, 2025

Merge activity

  • Nov 5, 1:28 AM UTC: @bgw merged this pull request with Graphite.

@bgw bgw deleted the bgw/dead-route-matcher branch November 5, 2025 01:28
huozhi pushed a commit that referenced this pull request Nov 12, 2025
Turns out this is all dead code, so delete it!

It looks like this was added back in vercel/turborepo#3448, probably when Turbopack was trying to rewrite larger parts of Next.js than ended up happening.
huozhi pushed a commit that referenced this pull request Nov 12, 2025
Turns out this is all dead code, so delete it!

It looks like this was added back in vercel/turborepo#3448, probably when Turbopack was trying to rewrite larger parts of Next.js than ended up happening.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

created-by: Turbopack team PRs by the Turbopack team. locked Turbopack Related to Turbopack with Next.js.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants