chore: fix types generation for eslint config package #85653
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Member
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Fixes the type definitions generation on eslint-config-next by setting the rootDir option, so it generates the .d.ts files in the dist folder instead of dist/src.
andreisena
force-pushed
the
fix-type-definitions-on-eslint-config
branch
from
7666a34 to
8728590
Compare
pull bot
pushed a commit
to Milan-960/next.js
that referenced
this pull request
Nov 4, 2025
`eslint-config-next` types were being emitted to `dist/src` instead of `dist/` during build. | Before | After | |--------|--------| | <img width="422" height="452" alt="CleanShot 2025-11-04 at 15 50 38@2x" src="https://github.com/user-attachments/assets/09c96d1a-41ba-4da9-87c6-bc05257c6e2a" /> | <img width="386" height="488" alt="CleanShot 2025-11-04 at 15 50 01@2x" src="https://github.com/user-attachments/assets/7b9802a4-e453-4086-90fb-a19e1aec7e20" /> | Fixes vercel#85379 Closes: vercel#84929 Closes: vercel#85653
huozhi
pushed a commit
that referenced
this pull request
Nov 12, 2025
`eslint-config-next` types were being emitted to `dist/src` instead of `dist/` during build. | Before | After | |--------|--------| | <img width="422" height="452" alt="CleanShot 2025-11-04 at 15 50 38@2x" src="https://github.com/user-attachments/assets/09c96d1a-41ba-4da9-87c6-bc05257c6e2a" /> | <img width="386" height="488" alt="CleanShot 2025-11-04 at 15 50 01@2x" src="https://github.com/user-attachments/assets/7b9802a4-e453-4086-90fb-a19e1aec7e20" /> | Fixes #85379 Closes: #84929 Closes: #85653
huozhi
pushed a commit
that referenced
this pull request
Nov 12, 2025
`eslint-config-next` types were being emitted to `dist/src` instead of `dist/` during build. | Before | After | |--------|--------| | <img width="422" height="452" alt="CleanShot 2025-11-04 at 15 50 38@2x" src="https://github.com/user-attachments/assets/09c96d1a-41ba-4da9-87c6-bc05257c6e2a" /> | <img width="386" height="488" alt="CleanShot 2025-11-04 at 15 50 01@2x" src="https://github.com/user-attachments/assets/7b9802a4-e453-4086-90fb-a19e1aec7e20" /> | Fixes #85379 Closes: #84929 Closes: #85653
Moroshima
pushed a commit
to Moroshima/next.js
that referenced
this pull request
Nov 20, 2025
`eslint-config-next` types were being emitted to `dist/src` instead of `dist/` during build. | Before | After | |--------|--------| | <img width="422" height="452" alt="CleanShot 2025-11-04 at 15 50 38@2x" src="https://github.com/user-attachments/assets/09c96d1a-41ba-4da9-87c6-bc05257c6e2a" /> | <img width="386" height="488" alt="CleanShot 2025-11-04 at 15 50 01@2x" src="https://github.com/user-attachments/assets/7b9802a4-e453-4086-90fb-a19e1aec7e20" /> | Fixes vercel#85379 Closes: vercel#84929 Closes: vercel#85653
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the type definitions generation on eslint-config-next by setting the rootDir option, so it generates the .d.ts files in the dist folder instead of dist/src.
Fixes #85568
Before
After